Page MenuHomePhabricator
Create Task
Maniphest T185599

VE spends time doing computed CSS to measure toolbars on init
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

DOM properties clientWidth/offsetWidth would probably be quicker

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (c5fddd508)mediawiki/extensions/VisualEditormaster+40 -15
Toolbars: Replace $.width with clientWidth/offsetWidthoojs/uimaster+2 -2
Toolbars: Replace $.height with clientHeight/offsetHeightmediawiki/extensions/VisualEditormaster+4 -2
Toolbars: Replace $.width with clientWidth/offsetWidthVisualEditor/VisualEditormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 23 2018, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2018, 7:57 PM
gerritbot subscribed.Jan 23 2018, 7:58 PM

Change 405931 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Toolbars: Replace $.width with clientWidth/offsetWidth

https://gerrit.wikimedia.org/r/405931

gerritbot added a project: Patch-For-Review.Jan 23 2018, 7:58 PM
gerritbot added a comment.Jan 23 2018, 8:12 PM

Change 405934 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Toolbars: Replace $.width with clientWidth/offsetWidth

https://gerrit.wikimedia.org/r/405934

gerritbot added a comment.Jan 23 2018, 8:32 PM

Change 405940 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Toolbars: Replace $.height with clientHeight/offsetHeight

https://gerrit.wikimedia.org/r/405940

gerritbot added a comment.Jan 23 2018, 10:55 PM

Change 405934 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Toolbars: Replace $.width with clientWidth/offsetWidth

https://gerrit.wikimedia.org/r/405934

gerritbot added a comment.Jan 23 2018, 11:01 PM

Change 405940 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Toolbars: Replace $.height with clientHeight/offsetHeight

https://gerrit.wikimedia.org/r/405940

gerritbot added a comment.Jan 23 2018, 11:14 PM

Change 405931 merged by jenkins-bot:
[oojs/ui@master] Toolbars: Replace $.width with clientWidth/offsetWidth

https://gerrit.wikimedia.org/r/405931

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 24 2018, 12:00 AM
gerritbot added a comment.Jan 27 2018, 2:21 AM

Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

gerritbot added a comment.Jan 29 2018, 4:57 PM

Change 405751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:15 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:15 PM
Krinkle awarded a token.Jan 30 2018, 10:44 PM
Jdforrester-WMF moved this task from Backlog to OOUI-0.25.2 on the OOUI board.Mar 1 2018, 7:54 PM
Jdforrester-WMF edited projects, added OOUI (OOUI-0.25.2); removed OOUI.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits