Page MenuHomePhabricator
Create Task
Maniphest T185696

Change default scope of “distinct values” constraint to main snak only
Closed, ResolvedPublic
Actions

Description

Per community discussion (now archived here), we probably want to change the default scope of UniqueValueChecker to only Context::TYPE_STATEMENT.

Details

SubjectRepoBranchLines +/-
Restrict default scope of UniqueValueCheckermediawiki/extensions/WikibaseQualityConstraintsmaster+0 -2
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 25 2018, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2018, 1:26 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 25 2018, 1:48 PM
Lucas_Werkmeister_WMDE added a subscriber: Lydia_Pintscher.Jan 30 2018, 4:58 PM

@Lydia_Pintscher I forgot about this task earlier, but is it okay if I add this to Wikidata-Sprint-2018-01-31? The code change is minimal.

Lydia_Pintscher added a comment.Jan 30 2018, 6:15 PM

Fine from my side.

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-31.Jan 30 2018, 6:23 PM
Liuxinyu970226 subscribed.Feb 1 2018, 2:41 PM
gerritbot subscribed.Feb 12 2018, 2:48 PM

Change 409901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Restrict default scope of UniqueValueChecker

https://gerrit.wikimedia.org/r/409901

gerritbot added a project: Patch-For-Review.Feb 12 2018, 2:48 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-31 board.Feb 12 2018, 2:48 PM
gerritbot added a comment.Feb 13 2018, 9:00 AM

Change 409901 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Restrict default scope of UniqueValueChecker

https://gerrit.wikimedia.org/r/409901

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 9:00 AM
WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2018-01-31 board.Feb 13 2018, 10:19 AM
Lydia_Pintscher closed this task as Resolved.Feb 13 2018, 1:20 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 15 2018, 1:45 PM
Liuxinyu970226 unsubscribed.Feb 17 2018, 3:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits