Page MenuHomePhabricator
Create Task
Maniphest T185749

Convert ContributionsList to use extension registration
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Convert ContributionsList to use extension registrationmediawiki/extensions/ContributionsListmaster+439 -33
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenGoalNoneT98668 Convert all extensions and skins on gerrit to use extension registration
ResolvedMarcoAurelioT185749 Convert ContributionsList to use extension registration
· · ·

Event Timeline

MarcoAurelio triaged this task as Low priority.Jan 26 2018, 12:17 PM
MarcoAurelio created this task.
Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptJan 26 2018, 12:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jan 26 2018, 12:38 PM

Change 406277 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/ContributionsList@master] Convert ContributionsList to use extension registration

https://gerrit.wikimedia.org/r/406277

gerritbot added a project: Patch-For-Review.Jan 26 2018, 12:38 PM
MarcoAurelio moved this task from unsorted/backlog to ready/patched/SWAT on the User-MarcoAurelio board.Jan 26 2018, 12:41 PM
Mainframe98 subscribed.Jan 26 2018, 1:38 PM

Full deprecation notice stack trace that I encountered while testing:

[error] [7413fdf58907661e641f99a4] /w/index.php?title=Test&action=submit   ErrorException from line 309 of /vagrant/mediawiki/includes/debug/MWDebug.php: PHP Deprecated: Use of Revision::pageJoinCond was deprecated in MediaWiki 1.31. [Called from ContributionsList::getQueryInfo in /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php at line 200]
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /vagrant/mediawiki/includes/debug/MWDebug.php(309): trigger_error(string, integer)
#2 /vagrant/mediawiki/includes/debug/MWDebug.php(241): MWDebug::sendMessage(string, array, string, integer)
#3 /vagrant/mediawiki/includes/GlobalFunctions.php(1181): MWDebug::deprecated(string, string, string, integer)
#4 /vagrant/mediawiki/includes/Revision.php(315): wfDeprecated(string, string)
#5 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(200): Revision::pageJoinCond()
#6 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(153): ContributionsList->getQueryInfo()
#7 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(129): ContributionsList->buildQueryInfo()
#8 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(117): ContributionsList->doQuery()
#9 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.hooks.php(58): ContributionsList->__construct(string, string, string, string, string)
#10 /vagrant/mediawiki/includes/parser/Parser.php(3407): ContributionsListHooks::contributionslistParserFunction(Parser, PPFrame_DOM, array)
#11 /vagrant/mediawiki/includes/parser/Parser.php(3108): Parser->callParserFunction(PPFrame_DOM, string, array)
#12 /vagrant/mediawiki/includes/parser/Preprocessor_DOM.php(1259): Parser->braceSubstitution(array, PPFrame_DOM)
#13 /vagrant/mediawiki/includes/parser/Parser.php(2923): PPFrame_DOM->expand(DOMElement, integer)
#14 /vagrant/mediawiki/includes/parser/Parser.php(1282): Parser->replaceVariables(string)
#15 /vagrant/mediawiki/includes/parser/Parser.php(443): Parser->internalParse(string)
#16 /vagrant/mediawiki/includes/content/WikitextContent.php(329): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#17 /vagrant/mediawiki/includes/content/AbstractContent.php(516): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)
#18 /vagrant/mediawiki/includes/EditPage.php(3998): AbstractContent->getParserOutput(Title, NULL, ParserOptions)
#19 /vagrant/mediawiki/includes/EditPage.php(3926): EditPage->doPreviewParse(WikitextContent)
#20 /vagrant/mediawiki/includes/EditPage.php(2673): EditPage->getPreviewText()
#21 /vagrant/mediawiki/includes/EditPage.php(705): EditPage->showEditForm()
#22 /vagrant/mediawiki/includes/actions/EditAction.php(60): EditPage->edit()
#23 /vagrant/mediawiki/includes/actions/SubmitAction.php(38): EditAction->show()
#24 /vagrant/mediawiki/includes/MediaWiki.php(500): SubmitAction->show()
#25 /vagrant/mediawiki/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#26 /vagrant/mediawiki/includes/MediaWiki.php(858): MediaWiki->performRequest()
#27 /vagrant/mediawiki/includes/MediaWiki.php(524): MediaWiki->main()
#28 /vagrant/mediawiki/index.php(42): MediaWiki->run()
#29 /var/www/w/index.php(5): require(string)
#30 {main}
MarcoAurelio added a comment.Jan 26 2018, 1:46 PM

so it's the $join_cond['page'] = Revision::pageJoinCond(); thing right?

MarcoAurelio added a comment.Jan 26 2018, 2:00 PM

https://doc.wikimedia.org/mediawiki-core/master/php/classRevision.html#a8f39133069c489febf784d137aca38b6

https://gerrit.wikimedia.org/r/#/c/406277/1/ContributionsList.class.php@200

Liuxinyu970226 added a project: MediaWiki-extensions-Other.Jan 26 2018, 3:26 PM
gerritbot added a comment.Feb 5 2018, 8:41 PM

Change 406277 merged by jenkins-bot:
[mediawiki/extensions/ContributionsList@master] Convert ContributionsList to use extension registration

https://gerrit.wikimedia.org/r/406277

MarcoAurelio added a comment.Feb 5 2018, 8:47 PM
In T185749#3924478, @Mainframe98 wrote:

Full deprecation notice stack trace that I encountered while testing:

I'll create a task to deprecate this so users can get some warnings before the extension breaks, if that's possible.

MarcoAurelio closed this task as Resolved.Feb 5 2018, 8:47 PM
MarcoAurelio removed a project: Patch-For-Review.

Conversion done.

MarcoAurelio moved this task from ready/patched/SWAT to cabinet on the User-MarcoAurelio board.Feb 5 2018, 10:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL