Page MenuHomePhabricator

Interaction Timeline: "time between” doesn’t display if the events are over midnight
Closed, ResolvedPublic1 Estimate Story Points

Description

Problem

The "time between" red information blocks do not display if the edits occur over midnight. We will display days differently in T181568 but this information is still helpful.


Acceptance criteria

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2018, 7:49 PM

Need to get an example of this for testing.

TBolliger renamed this task from Interaction Timeline: time between” doesn’t display if the events are over midnight to Interaction Timeline: "time between” doesn’t display if the events are over midnight.Feb 1 2018, 9:40 PM
TBolliger set the point value for this task to 1.
dbarratt claimed this task.Feb 27 2018, 3:00 PM
dbarratt moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 15) board.

The acceptance criteria say "should display in the first box" — but I forget our reasoning (arbitrary? deliberate?) so I'm 50/50 of what box it should appear in.

Either way, it looks fine like this. Ready to ship, for me!

The acceptance criteria say "should display in the first box" — but I forget our reasoning (arbitrary? deliberate?) so I'm 50/50 of what box it should appear in.
Either way, it looks fine like this. Ready to ship, for me!

oh... ha. I just happened to be there because that's the "row" it's in (I just removed the check to see if it's over midnight).

Great!