Interaction Timeline: "time between” doesn’t display if the events are over midnight
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• TBolliger
	Jan 30 2018, 7:49 PM

Description

Problem

The "time between" red information blocks do not display if the edits occur over midnight. We will display days differently in T181568 but this information is still helpful.

Acceptance criteria

The "Time between" message should display between all hand-offs of edits, regardless of which calendar dates the edits were made.
Should display in the first box (blocked by T181568: Interaction Timeline: Add a background box around all edits that are made on the same calendar day

Related Objects
Search...

Status	Assigned	Task
Resolved	• TBolliger	T166807 Epic ⚡️ : Interaction Timeline
Resolved	• TBolliger	T179607 Interaction Timeline V1
Resolved	dbarratt	T186043 Interaction Timeline: "time between” doesn’t display if the events are over midnight
Resolved	dbarratt	T181568 Interaction Timeline: Add a background box around all edits that are made on the same calendar day

Event Timeline

• TBolliger created this task.Jan 30 2018, 7:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2018, 7:49 PM

Need to get an example of this for testing.

• TBolliger added a parent task: T179607: Interaction Timeline V1.Feb 1 2018, 9:34 PM

• TBolliger renamed this task from Interaction Timeline: time between” doesn’t display if the events are over midnight to Interaction Timeline: "time between” doesn’t display if the events are over midnight.Feb 1 2018, 9:40 PM

• TBolliger updated the task description. (Show Details)Feb 14 2018, 7:58 PM

• TBolliger set the point value for this task to 1.

• TBolliger moved this task from Triage/To be Estimated to AHT Sprint 15 on the Anti-Harassment board.

• TBolliger edited projects, added Anti-Harassment (AHT Sprint 15); removed Anti-Harassment.

dbarratt added a subtask: T181568: Interaction Timeline: Add a background box around all edits that are made on the same calendar day.Feb 22 2018, 6:27 PM

dbarratt closed subtask T181568: Interaction Timeline: Add a background box around all edits that are made on the same calendar day as Resolved.Feb 26 2018, 8:05 PM

dbarratt claimed this task.Feb 27 2018, 3:00 PM

dbarratt moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 15) board.

https://phabricator.wikimedia.org/T186043

@TBolliger & @CSindersWMF What do you think?

Screenshot-2018-2-27 Interaction Timeline(2).png (1×2 px, 367 KB)

The acceptance criteria say "should display in the first box" — but I forget our reasoning (arbitrary? deliberate?) so I'm 50/50 of what box it should appear in.

Either way, it looks fine like this. Ready to ship, for me!

In T186043#4006614, @TBolliger wrote:

The acceptance criteria say "should display in the first box" — but I forget our reasoning (arbitrary? deliberate?) so I'm 50/50 of what box it should appear in.

Either way, it looks fine like this. Ready to ship, for me!

oh... ha. I just happened to be there because that's the "row" it's in (I just removed the check to see if it's over midnight).

Great!

https://tools.wmflabs.org/interaction-timeline/?wiki=testwiki&user=Derby%20pie&user=Sweets%20lover

	F14060538: Screenshot-2018-2-27 Interaction Timeline(2).png
	Feb 27 2018, 3:22 PM

Interaction Timeline: "time between” doesn’t display if the events are over midnightClosed, ResolvedPublic1 Estimated Story PointsActions