Page MenuHomePhabricator

Interaction Timeline: Add a background box around all edits that are made on the same calendar day
Closed, ResolvedPublic2 Story Points

Description

Problem to solve

We want a visual way to differentiate calendar dates on the Timeline, in addition to the left-positioned date indicators


Acceptance criteria

  • All edits that are made on the same calendar date should appear inside a new background element
  • It is Fine if the box has to readjust due to infinite scrolling
  • Use the colors depicted in the wireframe

Wireframe

Notes

This might take some restructuring of the HTML. Instead of the date being part of the "row" it will need to be it's own wrapper. This means the revisions might need to be broken up into map of Date -> List of Revisions. But I would just do that within the component (or within a selector, which is memorized).

Event Timeline

TBolliger set the point value for this task to 2.
dbarratt updated the task description. (Show Details)Dec 12 2017, 7:48 PM
dbarratt moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 15) board.
dmaza added a subscriber: dmaza.Feb 20 2018, 6:51 PM

@dbarratt the mock in the description shows different backgrounds (page/box) Can we get that in?

@dbarratt the mock in the description shows different backgrounds (page/box) Can we get that in?

The problem I have is... where does that background end? (at the top) it would go behind the form fields... or would it abruptly stop where the user heading is?

As discussed in today's standup: the light grey background will end at the top or bottom of the usernames (whatever David thinks looks best) and may blend into the footer.

Otherwise, looks good!

As discussed in today's standup: the light grey background will end at the top or bottom of the usernames (whatever David thinks looks best) and may blend into the footer.

What do you think?

  • dmaza added a comment.Feb 20 2018, 9:40 PM

    Looks good to me

    +1

    Does it look good on an empty query? while the loading indicator is spinning?

    +1
    Does it look good on an empty query? while the loading indicator is spinning?

    No background in that state (so it's the same as it is now).

    @TBolliger I added multiple screenshots in different states:


  • What do you think?

    Looks fine- I'd say there's maybe a smidge too much space (pls don't kill me).

    I vote we ship it but...I, after talking to Trevor, want to open the inspector tools on the finished product and just see what it would look like with an ENTIRELY white background. Thoughts on this?

    Yep, let's ship!

    I vote we ship it but...I, after talking to Trevor, want to open the inspector tools on the finished product and just see what it would look like with an ENTIRELY white background. Thoughts on this?

    I actually had it like that before... here's a screenshot:
    https://phab.wmfusercontent.org/file/data/jwrnyqspddt2fhab6x4c/PHID-FILE-v3vqdbcfri6jeoqbs6rw/Screenshot-2018-2-19_Interaction_Timeline.png

    but @dmaza rejected it in T181568#3986961