Page MenuHomePhabricator
Create Task
Maniphest T181568

Interaction Timeline: Add a background box around all edits that are made on the same calendar day
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Problem to solve

We want a visual way to differentiate calendar dates on the Timeline, in addition to the left-positioned date indicators

Acceptance criteria

  • All edits that are made on the same calendar date should appear inside a new background element
  • It is Fine if the box has to readjust due to infinite scrolling
  • Use the colors depicted in the wireframe

Wireframe

Screen Shot 2017-11-28 at 3.57.54 PM.png (816×959 px, 150 KB)

Notes

This might take some restructuring of the HTML. Instead of the date being part of the "row" it will need to be it's own wrapper. This means the revisions might need to be broken up into map of Date -> List of Revisions. But I would just do that within the component (or within a selector, which is memorized).

Related Objects
Search...

Event Timeline

• TBolliger created this task.Nov 28 2017, 9:59 PM
• TBolliger mentioned this in T179607: Interaction Timeline V1.
• TBolliger moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 30 2017, 7:42 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Dec 1 2017, 7:31 PM
• TBolliger set the point value for this task to 2.
dbarratt moved this task from Cards ready for development to AHT Sprint 11 on the Anti-Harassment board.Dec 6 2017, 8:10 PM
dbarratt edited projects, added Anti-Harassment (AHT Sprint 11); removed Anti-Harassment.
dbarratt updated the task description. (Show Details)Dec 12 2017, 7:48 PM
Huji added a project: InteractionTimeline.Dec 19 2017, 2:35 PM
• TBolliger moved this task from AHT Sprint 11 to Cards ready for development on the Anti-Harassment board.Jan 3 2018, 7:18 PM
• TBolliger edited projects, added Anti-Harassment; removed Anti-Harassment (AHT Sprint 11).
Chicocvenancio unsubscribed.Jan 23 2018, 3:36 AM
• TBolliger mentioned this in T186043: Interaction Timeline: "time between” doesn’t display if the events are over midnight.Jan 30 2018, 7:49 PM
• TBolliger moved this task from Cards ready for development to AHT Sprint 15 on the Anti-Harassment board.Feb 14 2018, 7:59 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 15); removed Anti-Harassment.
dbarratt claimed this task.Feb 17 2018, 12:43 AM
dbarratt moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 15) board.
dbarratt added a mock: M243: Timeline with Date Boxes.Feb 19 2018, 4:29 PM

@TBolliger & @CSindersWMF what do you think?

  • M243 Timeline with Date Boxes
    10

    • dbarratt moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 15) board.Feb 19 2018, 4:33 PM

    https://github.com/wikimedia/InteractionTimeline/pull/45

    dmaza subscribed.Feb 20 2018, 6:51 PM

    @dbarratt the mock in the description shows different backgrounds (page/box) Can we get that in?

    dbarratt added a comment.Feb 20 2018, 6:55 PM
    In T181568#3986961, @dmaza wrote:

    @dbarratt the mock in the description shows different backgrounds (page/box) Can we get that in?

    The problem I have is... where does that background end? (at the top) it would go behind the form fields... or would it abruptly stop where the user heading is?

    • TBolliger added a comment.Feb 20 2018, 7:27 PM

    As discussed in today's standup: the light grey background will end at the top or bottom of the usernames (whatever David thinks looks best) and may blend into the footer.

    Otherwise, looks good!

    dbarratt added a comment.Feb 20 2018, 9:25 PM
    In T181568#3987104, @TBolliger wrote:

    As discussed in today's standup: the light grey background will end at the top or bottom of the usernames (whatever David thinks looks best) and may blend into the footer.

    What do you think?

  • M243 Timeline with Date Boxes
    10

    • dmaza added a comment.Feb 20 2018, 9:40 PM

    Looks good to me

    • TBolliger added a comment.Feb 20 2018, 9:44 PM

    +1

    Does it look good on an empty query? while the loading indicator is spinning?

    dbarratt added a comment.Feb 20 2018, 9:45 PM
    In T181568#3987432, @TBolliger wrote:

    +1

    Does it look good on an empty query? while the loading indicator is spinning?

    No background in that state (so it's the same as it is now).

    • TBolliger added a comment.Feb 20 2018, 9:48 PM

    💯

    dbarratt added a parent task: T186043: Interaction Timeline: "time between” doesn’t display if the events are over midnight.Feb 22 2018, 6:27 PM
    • TBolliger mentioned this in T180089: Interaction Timeline V1: Header & footer.Feb 23 2018, 4:39 PM
    dbarratt added a comment.Feb 26 2018, 6:40 PM

    @TBolliger I added multiple screenshots in different states:

  • M243 Timeline with Date Boxes
    10

    • What do you think?

    dbarratt added a comment.Feb 26 2018, 7:08 PM

    @TBolliger Here's lot of days:

  • M243 Timeline with Date Boxes
    10

    • • CSindersWMF added a comment.Feb 26 2018, 7:50 PM

    Looks fine- I'd say there's maybe a smidge too much space (pls don't kill me).

    I vote we ship it but...I, after talking to Trevor, want to open the inspector tools on the finished product and just see what it would look like with an ENTIRELY white background. Thoughts on this?

    • TBolliger added a comment.Feb 26 2018, 7:52 PM

    Yep, let's ship!

    dbarratt added a comment.Feb 26 2018, 7:58 PM
    In T181568#4003086, @CSindersWMF wrote:

    I vote we ship it but...I, after talking to Trevor, want to open the inspector tools on the finished product and just see what it would look like with an ENTIRELY white background. Thoughts on this?

    I actually had it like that before... here's a screenshot:
    https://phab.wmfusercontent.org/file/data/jwrnyqspddt2fhab6x4c/PHID-FILE-v3vqdbcfri6jeoqbs6rw/Screenshot-2018-2-19_Interaction_Timeline.png

    but @dmaza rejected it in T181568#3986961

    dbarratt closed this task as Resolved.Feb 26 2018, 8:05 PM
    dbarratt moved this task from Review to Done on the Anti-Harassment (AHT Sprint 15) board.

    https://tools.wmflabs.org/interaction-timeline/?wiki=testwiki&user=Derby%20pie&user=Sweets%20lover

    Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL