Page MenuHomePhabricator

Improve display of local-exception checkboxes
Closed, ResolvedPublic2 Estimated Story Points

Description

As per discussion in T178267:

  • indent these lines, and
  • add a background colour on hover (to highlight the related preference).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Niharika set the point value for this task to 2.Jan 31 2018, 12:38 AM

Currently, the borders of the preferences htmlform table are not collapsed, and so we get lines when we hover:

If we set border-collapse:collapse then the form is slightly more compact than currently, and the hover background color looks better:

Is this okay?

Change 407187 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Improve styling of the local exception field

https://gerrit.wikimedia.org/r/407187

Change 407187 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Improve styling of the local exception field

https://gerrit.wikimedia.org/r/407187

The borders definitely don't look great, but I'm concerned this may turn into a game of whack-a-mole across multiple browsers. What's the best way to test this across multiple browser/OS combinations?

The main thing being changed is the border-collapse property (exchanging a 2px border-spacing with a 2px cell padding), which has full support in all browsers.

There are definitely improvements that can be made, but I think if OOUI for preferences is coming soon then it's better to wait.

Good to hear.

T117781 is just for Sp:Preferences. Do we want to create a task for Sp:GlobalPreferences?