As per discussion in T178267:
- indent these lines, and
- add a background colour on hover (to highlight the related preference).
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Improve styling of the local exception field | mediawiki/extensions/GlobalPreferences | master | +42 -2 |
Related Objects
Related Objects
- Mentioned In
- T178267: Dynamically enable/disable the related pref when toggling "Set a local exception for this global preference"
- Mentioned Here
- T186842: Convert Special:GlobalPreferences to OOUI
T117781: Convert Special:Preferences to OOUI
T178267: Dynamically enable/disable the related pref when toggling "Set a local exception for this global preference"
Event Timeline
Comment Actions
Currently, the borders of the preferences htmlform table are not collapsed, and so we get lines when we hover:
If we set border-collapse:collapse then the form is slightly more compact than currently, and the hover background color looks better:
Is this okay?
Comment Actions
Change 407187 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Improve styling of the local exception field
Comment Actions
Change 407187 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Improve styling of the local exception field
Comment Actions
The borders definitely don't look great, but I'm concerned this may turn into a game of whack-a-mole across multiple browsers. What's the best way to test this across multiple browser/OS combinations?
Comment Actions
The main thing being changed is the border-collapse property (exchanging a 2px border-spacing with a 2px cell padding), which has full support in all browsers.
There are definitely improvements that can be made, but I think if OOUI for preferences is coming soon then it's better to wait.
Comment Actions
Good to hear.
T117781 is just for Sp:Preferences. Do we want to create a task for Sp:GlobalPreferences?