Page MenuHomePhabricator

Support token or cert in conduit.connect
Closed, DeclinedPublic

Description

conduit.connect should support token or cert. Not just cert.

This is needed to completely resolve T186370

We need to be able to get the sessionKey.

Upstream recommend we use the tokens over certs so i doin't understand why conduit.connect only takes the cert.

Event Timeline

Paladox triaged this task as High priority.Feb 3 2018, 1:58 PM

Needs to be fixed so setting high priority to prevent a repeat of T186370

Also because the its-phabricator plugin logs the cert we cannot go back to certs to prevent a security breach of the bot.

by token i mean cli-* or api-*

and should deprecate authToken and authSignature so we should have a new field called token. So that token or authSignature and authToken have to be set.

(i need access to the sessionKey generated when connecting with conduit.connect)

As far as I understand it, token was introduced to replace the need for establishing a session with conduit.connect. So, a conduit token is equivalent to a sessionKey, you just need to include &token=$token with every request to conduit and you don't need conduit.connect anymore.

Thanks. Will create a wip upstream for this :).

This is needed to completely resolve T186370

T186370 is resolved. @Paladox: Is this still an issue (and high priority)?

Nope, can decline it for now.