Page MenuHomePhabricator

Thumbor won't render some SVGs whose namespace is too far into the file
Closed, ResolvedPublic

Description

This file used to render fine: https://de.wikipedia.org/wiki/Datei:BuickLogo_silber.svg and now doesn't with Thumbor. It has a large amount of entities before the SVG namespace appears, which is probably why that doesn't get picked up, it's probably beyond the length limit of the buffer excerpt.

Maybe we should relax our is_svg check to just not check the namespace presence and try anything that starts with <?xml or <?svg ? In which case the SVG engine should be one of the last to be tried in the list of engines.

Details

Related Gerrit Patches:
operations/debs/python-thumbor-wikimedia : masterUpgrade to 1.13

Event Timeline

Gilles created this task.Feb 12 2018, 4:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2018, 4:19 PM
Gilles triaged this task as Low priority.Feb 12 2018, 4:20 PM
Gilles updated the task description. (Show Details)

Change 410417 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

https://gerrit.wikimedia.org/r/410417

Change 410417 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

https://gerrit.wikimedia.org/r/410417

Gilles closed this task as Resolved.Feb 14 2018, 4:02 PM