Page MenuHomePhabricator

Thumbor won't render some SVGs whose namespace is too far into the file
Closed, ResolvedPublic


This file used to render fine: and now doesn't with Thumbor. It has a large amount of entities before the SVG namespace appears, which is probably why that doesn't get picked up, it's probably beyond the length limit of the buffer excerpt.

Maybe we should relax our is_svg check to just not check the namespace presence and try anything that starts with <?xml or <?svg ? In which case the SVG engine should be one of the last to be tried in the list of engines.

Revisions and Commits

rTHMBREXT Thumbor Plugins
Restricted Differential Revision

Event Timeline

Gilles updated the task description. (Show Details)
Gilles added a revision: Restricted Differential Revision.Feb 13 2018, 2:34 PM

Change 410417 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

Change 410417 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13