Page MenuHomePhabricator

Thumbor errors should contain a trackable request id
Closed, ResolvedPublic

Description

At the moment there's no way to tie a Thumbor error encountered from the client's perspective to its corresponding log entry in logstash. Setting up a request id, preferably at the nginx level, returned as part of the response headers should do the trick.

Event Timeline

Gilles created this task.Nov 7 2017, 4:39 PM
Gilles removed a project: Multimedia.

Change 405864 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/vagrant@master] Add Thumbor Request-Id generated by nginx

https://gerrit.wikimedia.org/r/405864

Change 407411 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/puppet@production] Add Thumbor-Request-Id generated by nginx

https://gerrit.wikimedia.org/r/407411

Change 405864 merged by jenkins-bot:
[mediawiki/vagrant@master] Add Thumbor-Request-Id generated by nginx

https://gerrit.wikimedia.org/r/405864

Change 407412 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.11

https://gerrit.wikimedia.org/r/407412

Change 407412 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.11

https://gerrit.wikimedia.org/r/407412

Change 407411 merged by Filippo Giunchedi:
[operations/puppet@production] Add Thumbor-Request-Id generated by nginx

https://gerrit.wikimedia.org/r/407411

Works for exceptions, not included (yet?) in manual logger.error calls coming from our code.

Change 410417 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

https://gerrit.wikimedia.org/r/410417

Change 410417 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

https://gerrit.wikimedia.org/r/410417

Gilles closed this task as Resolved.Feb 14 2018, 4:10 PM