Page MenuHomePhabricator
Create Task
Maniphest T179954

Thumbor errors should contain a trackable request id
Closed, ResolvedPublic
Actions

Description

At the moment there's no way to tie a Thumbor error encountered from the client's perspective to its corresponding log entry in logstash. Setting up a request id, preferably at the nginx level, returned as part of the response headers should do the trick.

Details

ProjectBranchLines +/-Subject
operations/debs/python-thumbor-wikimediamaster+38 K -95Upgrade to 1.13
operations/puppetproduction+3 -1Add Thumbor-Request-Id generated by nginx
operations/debs/python-thumbor-wikimediamaster+117 -38Upgrade to 1.11
mediawiki/vagrantmaster+2 -1Add Thumbor-Request-Id generated by nginx
Customize query in gerrit

Revisions and Commits

rTHMBREXT Thumbor Plugins
rTHMBREXT5be43e413989 Version bump
D974rTHMBREXT64bc4a88f4ab Add thumbor-request-id to all custom logger.error
D950rTHMBREXT0469281059fa Forward Thumbor-Request-Id received from nginx, if any
rTHMBREXTc9188c0e1125 Version bump

Related Objects
Search...

Event Timeline

• Gilles created this task.Nov 7 2017, 4:39 PM
• Gilles removed a project: Multimedia.
Tgr added a parent task: T157850: Interacting with Wikimedia logs should be a pleasant experience.Nov 7 2017, 5:04 PM
• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Nov 13 2017, 9:35 PM
Clarkcj12 moved this task from Backlog: Maintenance, non-prioritized to Inbox, needs triage on the Performance-Team board.Jan 13 2018, 2:05 AM
• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jan 16 2018, 2:22 PM
• Gilles added a revision: D950: Forward Thumbor-Request-Id received from nginx, if any.Jan 23 2018, 10:43 AM
• Gilles added a project: Patch-For-Review.Jan 23 2018, 10:43 AM
gerritbot added a subscriber: gerritbot.Jan 23 2018, 10:47 AM

Change 405864 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/vagrant@master] Add Thumbor Request-Id generated by nginx

https://gerrit.wikimedia.org/r/405864

gerritbot added a comment.Feb 1 2018, 11:03 AM

Change 407411 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/puppet@production] Add Thumbor-Request-Id generated by nginx

https://gerrit.wikimedia.org/r/407411

gerritbot added a comment.Feb 1 2018, 11:04 AM

Change 405864 merged by jenkins-bot:
[mediawiki/vagrant@master] Add Thumbor-Request-Id generated by nginx

https://gerrit.wikimedia.org/r/405864

• Gilles added a commit: rTHMBREXTc9188c0e1125: Version bump.Feb 1 2018, 11:06 AM
• Gilles added a commit: rTHMBREXT0469281059fa: Forward Thumbor-Request-Id received from nginx, if any.
gerritbot added a comment.Feb 1 2018, 11:08 AM

Change 407412 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.11

https://gerrit.wikimedia.org/r/407412

gerritbot added a comment.Feb 1 2018, 1:17 PM

Change 407412 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.11

https://gerrit.wikimedia.org/r/407412

• Gilles removed a project: Patch-For-Review.Feb 1 2018, 4:41 PM
Stashbot mentioned this in T178072: Thumbor: Error reading image metadata: Failed to read image data.Feb 2 2018, 9:57 AM
Stashbot mentioned this in T185478: Measure time spent by Thumbor connecting to and reading from Swift.
Stashbot mentioned this in T185483: Measure time spent by Thumbor connecting to and reading from Memcache.
Stashbot mentioned this in T185485: Measure time spent by Thumbor connecting to and reading from Poolcounter.
Stashbot mentioned this in T183907: Thumbor 500 while thumbnailing some webm files.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-02-02T09:57:08Z] <godog> roll-upgrade thumbor to 1.11 - T178072 T185478 T185483 T185485 T183907 T179954

gerritbot added a comment.Feb 2 2018, 11:47 AM

Change 407411 merged by Filippo Giunchedi:
[operations/puppet@production] Add Thumbor-Request-Id generated by nginx

https://gerrit.wikimedia.org/r/407411

• Gilles closed subtask T186492: Improve Thumbor error logging as Resolved.EditedFeb 12 2018, 3:30 PM

Works for exceptions, not included (yet?) in manual logger.error calls coming from our code.

• Gilles added a revision: D974: Add thumbor-request-id to all custom logger.error.Feb 13 2018, 1:42 PM
• Gilles added a project: Patch-For-Review.Feb 13 2018, 1:42 PM
• Gilles added a commit: rTHMBREXT64bc4a88f4ab: Add thumbor-request-id to all custom logger.error.Feb 13 2018, 4:18 PM
• Gilles added a commit: rTHMBREXT5be43e413989: Version bump.Feb 14 2018, 10:25 AM
gerritbot added a comment.Feb 14 2018, 10:27 AM

Change 410417 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

https://gerrit.wikimedia.org/r/410417

gerritbot added a comment.Feb 14 2018, 2:25 PM

Change 410417 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.13

https://gerrit.wikimedia.org/r/410417

Stashbot mentioned this in T187159: Add prefixes to custom Thumbor headers.Feb 14 2018, 3:24 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-14T15:24:08Z] <godog> roll-upgrade thumbor to 1.13 - T187159 T179954 T187088

Stashbot mentioned this in T187088: Thumbor won't render some SVGs whose namespace is too far into the file.Feb 14 2018, 3:24 PM
• Gilles closed this task as Resolved.Feb 14 2018, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL