Page MenuHomePhabricator
Create Task
Maniphest T186492

Improve Thumbor error logging
Closed, ResolvedPublic
Actions

Description

Currently there are duplicate error log messages in logstash, half of which contain insufficient information.

Details

SubjectRepoBranchLines +/-
Improve Thumbor error loggingmediawiki/vagrantmaster+7 -3
Improve Thumbor error loggingoperations/puppetproduction+15 -1
Upgrade to 1.12operations/debs/python-thumbor-wikimediamaster+228 -4
Customize query in gerrit

Revisions and Commits

rTHMBREXT Thumbor Plugins
rTHMBREXT3d0030df230f Version bump
Restricted Differential RevisionrTHMBREXTeb7a8ea85b35 Make Poolcounter throttling message less unique
Restricted Differential RevisionrTHMBREXT38dfadc6d2f1 Improve Thumbor error logging

Related Objects
Search...

Event Timeline

• Gilles triaged this task as Medium priority.Feb 5 2018, 9:33 AM
• Gilles created this task.
• Gilles added a revision: Restricted Differential Revision.Feb 5 2018, 10:19 AM
• Gilles added a project: Patch-For-Review.Feb 5 2018, 1:32 PM
• Gilles added a commit: rTHMBREXT38dfadc6d2f1: Improve Thumbor error logging.Feb 5 2018, 2:12 PM
• Gilles added a revision: Restricted Differential Revision.Feb 5 2018, 2:17 PM
• Gilles added a commit: rTHMBREXTeb7a8ea85b35: Make Poolcounter throttling message less unique.Feb 5 2018, 7:42 PM
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Feb 5 2018, 9:08 PM
• Gilles added a commit: rTHMBREXT3d0030df230f: Version bump.Feb 9 2018, 11:39 AM
gerritbot added a comment.Feb 9 2018, 11:40 AM

Change 409314 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.12

https://gerrit.wikimedia.org/r/409314

gerritbot added a comment.Feb 9 2018, 11:58 AM

Change 409316 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/vagrant@master] Improve Thumbor error logging

https://gerrit.wikimedia.org/r/409316

gerritbot added a comment.Feb 9 2018, 12:01 PM

Change 409319 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/puppet@production] Improve Thumbor error logging

https://gerrit.wikimedia.org/r/409319

gerritbot added a comment.Feb 9 2018, 2:20 PM

Change 409314 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.12

https://gerrit.wikimedia.org/r/409314

fgiunchedi added a project: User-fgiunchedi.Feb 12 2018, 9:03 AM
fgiunchedi moved this task from Backlog to Doing on the User-fgiunchedi board.
Stashbot mentioned this in T186500: Thumbor failing on some SVGs with "ValueError: invalid literal for int() with base 10".Feb 12 2018, 3:00 PM
Stashbot mentioned this in T186594: Log time when request makes it to Thumbor.

Mentioned in SAL (#wikimedia-operations) [2018-02-12T15:00:58Z] <godog> roll-upgrade thumbor to 1.12 - T186500 T186594 T186492

gerritbot added a comment.Feb 12 2018, 3:07 PM

Change 409319 merged by Filippo Giunchedi:
[operations/puppet@production] Improve Thumbor error logging

https://gerrit.wikimedia.org/r/409319

• Gilles closed this task as Resolved.Feb 12 2018, 3:30 PM

No more dupes, traceback is still there for uncaught exceptions.

gerritbot added a comment.Feb 13 2018, 12:55 PM

Change 409316 merged by jenkins-bot:
[mediawiki/vagrant@master] Improve Thumbor error logging

https://gerrit.wikimedia.org/r/409316

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits