Log time when request makes it to Thumbor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Feb 6 2018, 11:47 AM

Description

At the moment we only log that information from nginx's perspective, and there can be a lot of unaccounted time. It could be in nginx request queueing, or in tornado's (thumbor).

Details

Subject	Repo	Branch	Lines +/-
Whitelist new Thumbor-Request-Date header in Swift	operations/puppet	production	+2 -1
Upgrade to 1.12	operations/debs/python-thumbor-wikimedia	master	+228 -4
Add Thumbor-Request-Date to Swift header whitelist	mediawiki/vagrant	master	+17 -1

Customize query in gerrit

Revisions and Commits

rTHMBREXT Thumbor Plugins
		rTHMBREXT3d0030df230f Version bump
	Restricted Differential Revision	rTHMBREXTdb19799d17f2 Record time when thumbor receives the request

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Gilles	T185466 Review Varnish slow log for upload.wikimedia.org
		Resolved		• Gilles	T186594 Log time when request makes it to Thumbor

Event Timeline

• Gilles triaged this task as Medium priority.Feb 6 2018, 11:47 AM

• Gilles created this task.

• Gilles added a revision: Restricted Differential Revision.Feb 6 2018, 12:14 PM

• Gilles added a project: Patch-For-Review.Feb 6 2018, 12:15 PM

• Gilles added a commit: rTHMBREXTdb19799d17f2: Record time when thumbor receives the request.Feb 8 2018, 2:08 PM

• Gilles added a commit: rTHMBREXT3d0030df230f: Version bump.Feb 9 2018, 11:39 AM

Change 409314 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.12

https://gerrit.wikimedia.org/r/409314

Change 409315 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/vagrant@master] Add Thumbor-Request-Date to Swift header whitelist

https://gerrit.wikimedia.org/r/409315

Change 409315 merged by jenkins-bot:
[mediawiki/vagrant@master] Add Thumbor-Request-Date to Swift header whitelist

https://gerrit.wikimedia.org/r/409315

Change 409314 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.12

https://gerrit.wikimedia.org/r/409314

Mentioned in SAL (#wikimedia-operations) [2018-02-12T15:00:58Z] <godog> roll-upgrade thumbor to 1.12 - T186500 T186594 T186492

Stashbot mentioned this in T186492: Improve Thumbor error logging.Feb 12 2018, 3:01 PM

Show up in the Varnish slow log. Not exposed in thumbnail responses sent to the actual client, but I think that's ok. This was added to attempt to figure out some slow log mysteries.

Actually doesn't show up for 200s yet, but I think that's because the swift proxy filtering kicks in only in this case (which is interesting in itself - error responses aren't subject to the header filtering).

Change 409942 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/puppet@production] Whitelist new Thumbor-Request-Date header in Swift

https://gerrit.wikimedia.org/r/409942

Change 409942 merged by Filippo Giunchedi:
[operations/puppet@production] Whitelist new Thumbor-Request-Date header in Swift

https://gerrit.wikimedia.org/r/409942

• Gilles closed this task as Resolved.Feb 13 2018, 10:35 AM