Page MenuHomePhabricator

Figure out why HHVM isn't using error_document404 setting
Closed, DuplicatePublic

Description

The mediawiki puppet module configures HHVM to use /srv/mediawiki/errorpages/404.php for its error_document404 setting.

Per https://github.com/wikimedia/puppet/blob/373c3e8e5b/modules/mediawiki/manifests/hhvm.pp#L40.

However, when requesting a url that (I believe) is routed by Apache to HHVM, this error template isn't used.

Per https://github.com/wikimedia/puppet/blob/e959321aa/modules/mediawiki/files/apache/sites/main.conf#L274

For a url like https://en.wikipedia.org/w/foo.php, some basic default is being served instead:

Screen Shot 2018-02-19 at 15.52.27.png (334×910 px, 27 KB)

In order to be able to update the look of this 404 (parent task) we first need to figure out where this response is coming from, and how to change it. If it isn't coming from HHVM, then from where? If it comes from Apache (next best guess), then why isn't Apache using the 404 handler we've configured there?

Per https://github.com/wikimedia/puppet/blob/e959321aa6/modules/mediawiki/templates/apache/apache2.conf.erb#L85

Event Timeline

Krinkle updated the task description. (Show Details)
RobH triaged this task as Medium priority.May 3 2018, 4:51 PM
RobH subscribed.

As part of SRE clinic duty, I'm reviewing all unassigned, needs triage tasks in SRE and attempting to review if any are critical, or if they are normal priority.

This task appears to be normal priority, and I have set it such. If any one on this task disagrees, please comment and correct.

Thanks!