Page MenuHomePhabricator
Create Task
Maniphest T187780

Historical diffs should be hidden when user agent has disabled Javascript
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This feature depends completely on JS, but the buttons are not hidden when the page is loaded by a user agent without Javascript enabled.

Screen Shot 2018-02-20 at 14.35.40.png (422×1 px, 75 KB)

Details

SubjectRepoBranchLines +/-
Hide historical diff controls when UA doesn't support JSmediawiki/extensions/VisualEditormaster+4 -0
Customize query in gerrit

Event Timeline

TheDJ created this task.Feb 20 2018, 1:45 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 20 2018, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Feb 20 2018, 1:49 PM

Change 412913 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/VisualEditor@master] Hide historical diff controls when UA doesn't support JS

https://gerrit.wikimedia.org/r/412913

gerritbot added a project: Patch-For-Review.Feb 20 2018, 1:49 PM
TheDJ triaged this task as Lowest priority.Feb 20 2018, 1:51 PM
Esanders assigned this task to TheDJ.Feb 20 2018, 2:44 PM
Esanders subscribed.

Thanks!

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Feb 20 2018, 2:45 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Feb 20 2018, 5:03 PM

Change 412913 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Hide historical diff controls when UA doesn't support JS

https://gerrit.wikimedia.org/r/412913

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 20 2018, 6:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 20 2018, 6:40 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 20 2018, 6:58 PM
• Deskana closed this task as Resolved.Feb 22 2018, 12:10 PM
• Deskana subscribed.

Thanks @TheDJ !

• Deskana set the point value for this task to 1.Feb 22 2018, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL