Page MenuHomePhabricator
Create Task
Maniphest T187904

3d2png tests fail
Closed, ResolvedPublic
Actions

Description

3d2png's tests fail for me with node 9.5 on macos 10.3. Some patches:

I'm not certain that my new rendering is correct in terms of texture/background, but I notice that the direction of view has changed recently and the sample rendering didn't get updated, causing a wildly mismatched MSSIM value.

Related Objects

Event Timeline

• brooke created this task.Feb 21 2018, 4:26 PM
Restricted Application edited projects, added Multimedia; removed Patch-For-Review. · View Herald TranscriptFeb 21 2018, 4:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Ramsey-WMF assigned this task to matthiasmullie.Feb 21 2018, 7:22 PM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Feb 26 2018, 8:37 PM
• Ramsey-WMF added a project: Multimedia-Team-Working-Board.
hashar subscribed.Mar 8 2018, 9:34 PM

@brion All your patches got merged and CI (node 6) is all happy about it.

When the /deploy submodule is updated, the tests will pass there as well. Tested it on patchset 2 of https://gerrit.wikimedia.org/r/#/c/417276/ (that change is not to be reused).

Kudos!

hashar mentioned this in T187797: Migrate leftover Nodepool jobs to Docker.Mar 8 2018, 9:35 PM
matthiasmullie closed this task as Resolved.Mar 19 2018, 8:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits