Page MenuHomePhabricator

3d2png tests fail
Closed, ResolvedPublic


3d2png's tests fail for me with node 9.5 on macos 10.3. Some patches:

I'm not certain that my new rendering is correct in terms of texture/background, but I notice that the direction of view has changed recently and the sample rendering didn't get updated, causing a wildly mismatched MSSIM value.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@brion All your patches got merged and CI (node 6) is all happy about it.

When the /deploy submodule is updated, the tests will pass there as well. Tested it on patchset 2 of (that change is not to be reused).