Fri, Apr 19
I tested this on beta commons on 4-19 and confirmed it is a bug in the mobile skin. Visiting the desktop site via mobile works though.
Tue, Apr 16
I've tested it and this works for me. One question though: what happens when it's a statement with a data type we don't yet support?
The current implementation looks good but I wonder if we need some sort of messaging to explain why some things are gray. Then, of course, the question would be where to put such messaging. If this were going to be a forever feature, I'd say we definitely need some explanatory text somewhere. But since this is (hopefully) going to be both temporary and rare, I question how much effort we should put it into it. Also pinging @PDrouin-WMF for input.
We could either replace the entire content (or just the widgets) with some "statements are being published"
After a few tests, have been unable to reproduce this on Test commons (with a new upload, with an old upload that didn't have depicts yet, etc.). Will move to VoP for now, but I'm still a little wary about this one.
Mon, Apr 15
Hmm. I'm gonna test this one a bit more in multiple languages. Tagging the rest of the team for additional eyes on it/insight
Thanks for the useful notes @matthiasmullie . Pam and I share a lot of these sentiments. We're just trying to address some external concerns about whether the new additional "publish" step at Add Data is confusing to new users.
Fri, Apr 12
@PDrouin-WMF how about changing the Describe text to:
Thu, Apr 11
@matthiasmullie I protected this file on Beta for testing: https://commons.wikimedia.beta.wmflabs.org/wiki/File:3dcrystal.gif
Wed, Apr 10
I confirmed that it didn't work, then made an edit to it while logged in, and that worked. When I logged out and tried to make an edit again...it worked the second time around. So you can't use those steps above to reproduce it anymore, it seems :(
Assigning to Matthias for now, our statement panel master :)
tested on beta and test commons. throwing over to @PDrouin-WMF
Closing this, as the current fix resolved this specific problem and user testing showed we definitely don't want to do the automatic display of the qualifier window on the first few runs. We may go with a different system for search qualifiers in general. TBD.
Tested and working on both Beta and Test. Throwing it over to Pam for design comments.
As promised, since it looks like we're going to tweak this and go in a different direction, going to close this one and start new ticket(s) when we have made more decisions on what's next.
Looks good on Beta (not on test commons yet). What say you, @PDrouin-WMF ?
Confirmed that this works on Beta, but the code has not hit test Commons yet. Want to take a look, @PDrouin-WMF ?
Tue, Apr 9
Unfortunately, this code isn't something we can support either (no C programmers on the team, overloaded with SDC now, etc.)
For depicts, we'll start with:
Mon, Apr 8
Fri, Apr 5
Tested and passed on test commons. Throwing over to @PDrouin-WMF
It's working now. Still a bit weird though. I think the problem is the first run scenario where, for the first few times you add a tag, we automatically show the qualifier popover as soon as you add it. The popover ends up behind the keyword and tags buttons and is jarring.
Thu, Apr 4
Wed, Apr 3
I'd like to confirm it, but autosuggest dropdowns aren't appearing on Labs right now :)
Will fill out the ticket more later.