Page MenuHomePhabricator

Media Search: Adjust margin on image grid to line up
Closed, ResolvedPublic

Description

Currently the images are inset from the outer boundary of the "page". I think if we were able to remove the outer left and right margin we could gain some space and clean up the lines / clutter of the page.

margins.jpg (816×2 px, 580 KB)

Event Timeline

Change 622448 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Update QuickView layout

https://gerrit.wikimedia.org/r/622448

Change 622448 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update QuickView layout

https://gerrit.wikimedia.org/r/622448

Ramsey-WMF added a subscriber: Ramsey-WMF.

I spot checked this on Beta and it looks like the left margin is gone but the right one is not. Could use another set of eyes on it 👀

@Ramsey-WMF is correct! Right margin isn't adjusted, not a huge deal / major priority but would be nice to get to at some point.

Change 629478 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix images/videos grid margin

https://gerrit.wikimedia.org/r/629478

Change 629478 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix images/videos grid margin

https://gerrit.wikimedia.org/r/629478

Etonkovidova added a subscriber: Etonkovidova.

The patch is in place -

.wbmi-media-search-results__list--video, .wbmi-media-search-results__list--bitmap {   
    display: flex; 
    flex-wrap: wrap;
    margin: -8px;
    max-width: calc(100% + 16px);
}
betalabsproduction wmf.10
Screen Shot 2020-10-02 at 5.01.48 PM.png (584×1 px, 899 KB)
Screen Shot 2020-10-02 at 5.02.11 PM.png (663×1 px, 862 KB)
Screen Shot 2020-10-02 at 5.10.37 PM.png (535×1 px, 216 KB)
Screen Shot 2020-10-02 at 5.12.16 PM.png (647×1 px, 479 KB)

Also checked for possible regression

  • on mobile
  • did a standard cross-browser testing
  • old/new Vector skin