Page MenuHomePhabricator

[S] Remove focus from search input after searching in Media Search
Closed, ResolvedPublicBUG REPORT

Description

We have this: After you perform a search in Media Search, the focus stays in the search input after searching, so pressing space to scroll to see more images doesn't work unless you click outside the search input. Instead, pressing space adds a space character to the search input.

We want this: After you perform a search in Media Search, remove focus from the search input, so that pressing space to scroll works as expected.

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser

Event Timeline

@mwilliams, we're assuming that the desired behavior here is to blur the search input, can you confirm?

CBogen renamed this task from Remove focus from search input after searching in Media Search to [S] Remove focus from search input after searching in Media Search.Sep 9 2020, 4:39 PM

4 months later I respond...

I think removing the focus on the input after submitting a search to allow scrolling with the space bar makes sense. I'm a little concerned about how this affects accessibility but it does follow the pattern of all the major search engines and seems like a worthy update.

Change 668180 had a related patch set uploaded (by Seddon; owner: Seddon):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove focus from input post search in MediaSearch

https://gerrit.wikimedia.org/r/668180

Change 668180 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove focus from input post search in MediaSearch

https://gerrit.wikimedia.org/r/668180

Etonkovidova updated the task description. (Show Details)