Page MenuHomePhabricator
Create Task
Maniphest T258543

SDC: SimpleCacheWithBagOStuff throwing CacheInvalidArgumentException due to invalid cache key on Commons
Closed, ResolvedPublic
Actions

Description

A couple examples from today's commonswiki error log:

Wikibase\Lib\CacheInvalidArgumentException from line 282 of /srv/mediawiki/php-1.35.0-wmf.41/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php: Cache key contains characters that are not allowed: `Q484768_982

Wikibase\Lib\CacheInvalidArgumentException from line 282 of /srv/mediawiki/php-1.35.0-wmf.41/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php: Cache key contains characters that are not allowed: `Q274193_123

I'm not sure what's causing it, but I assume it's related to SDC since the error is thrown by Wikibase.

Related Objects

Event Timeline

kaldari created this task.Jul 21 2020, 11:35 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptJul 21 2020, 11:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kaldari renamed this task from SDC throwing fatal error due to invalid cache key to SDC throwing exception due to invalid cache key.Jul 21 2020, 11:39 PM
• Ramsey-WMF added a project: Wikidata.Jul 21 2020, 11:49 PM
• Ramsey-WMF added subscribers: Ladsgroup, Addshore, hoo, • Ramsey-WMF.

This looks like T245396, which @Ladsgroup @Addshore and @hoo worked on just a few months ago. I think they have more expertise here than we do 🙂

Krinkle renamed this task from SDC throwing exception due to invalid cache key to SDC: SimpleCacheWithBagOStuff throwing CacheInvalidArgumentException due to invalid cache key on Commons.Jul 22 2020, 2:16 AM
Krinkle triaged this task as High priority.
Krinkle moved this task from Untriaged to Jul 2020 on the Wikimedia-production-error board.
Krinkle added a project: Wikidata-Campsite.
Ladsgroup added a subscriber: Michael.Jul 22 2020, 10:51 PM

This thing again. It's like a whac-a-mole now. @Michael done the most recent work on it AFAIK.

Michael added a comment.Jul 24 2020, 10:59 AM

This seems to have been one single spike over a span of maybe 3 minutes on 2020-07-19:

image.png (242×450 px, 7 KB)
image.png (188×1 px, 19 KB)

Maybe some strange misaligned versions during deployment?

CBogen moved this task from Triage to Tracking on the Structured-Data-Backlog board.Jul 27 2020, 4:38 PM
Umherirrender subscribed.Mar 6 2021, 4:36 PM

The regex was changed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/607544 and now the underscore is allowed. I would assume this cannot happen again. Please have a look at the logs if there are still issuses.

The patch set is part of wmf/1.35.0-wmf.40, while this error is filled under wmf/1.35.0-wmf.39, but the stacktrace shows .41

Also related:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/607579

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptMar 6 2021, 4:36 PM
Addshore closed this task as Resolved.Mar 9 2021, 11:34 PM
Addshore claimed this task.

I'll go ahead and resolve this for now!

Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 9 2021, 11:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL