[M] Media Search: Center loading icon under grid when quick view is open
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	mwilliams
	Aug 6 2020, 9:36 PM

Description

Currently the loading indicator sits underneath both the results and the quick view when it is activated.

Can we center the loading indicator underneath the grid, since that is what is loading?

Details

	Subject	Repo	Branch	Lines +/-
	Move loading icon and loading state components into SearchResults	mediawiki/extensions/WikibaseMediaInfo	master	+125 -109

Customize query in gerrit

Event Timeline

mwilliams created this task.Aug 6 2020, 9:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2020, 9:36 PM

mwilliams updated the task description. (Show Details)Aug 6 2020, 10:34 PM

mwilliams added a project: SDAW-MediaSearch (MediaSearch-Beta).Aug 7 2020, 6:24 PM

mwilliams updated the task description. (Show Details)

mwilliams moved this task from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

mwilliams added subscribers: CBogen, • Ramsey-WMF.

CBogen renamed this task from Media Search: Center loading icon under grid when quick view is open to [S] Media Search: Center loading icon under grid when quick view is open.Aug 26 2020, 4:29 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.

• Ramsey-WMF edited projects, added SDAW-MediaSearch, Structured-Data-Backlog; removed SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work).Sep 9 2020, 7:09 PM

• Ramsey-WMF moved this task from Triage to Section Topics on the Structured-Data-Backlog board.

CBogen moved this task from Backlog to MediaSearch-ReleaseCandidate2 on the SDAW-MediaSearch board.Oct 6 2020, 4:01 PM

CBogen edited projects, added SDAW-MediaSearch (MediaSearch-ReleaseCandidate2); removed SDAW-MediaSearch.

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 8 2020, 3:29 PM

Changing this to medium because it involves either a nontrivial architectural change, or adding something to state to indicate whether QuickView is open... cc @egardner

Change 655181 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Move loading icon and "load more" button to SearchResults component

https://gerrit.wikimedia.org/r/655181

gerritbot added a project: Patch-For-Review.Jan 9 2021, 1:58 AM

AnneT moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 9 2021, 4:46 AM

Change 655181 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Move loading icon and loading state components into SearchResults

https://gerrit.wikimedia.org/r/655181

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2021, 1:10 AM

egardner moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 14 2021, 1:11 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 14 2021, 2:00 AM

Checked in commons wmf.27 - looks as expected:

Screen Shot 2021-01-20 at 3.37.54 PM.png (356×1 px, 147 KB)

	F34009950: Screen Shot 2021-01-20 at 3.37.54 PM.png
	Jan 20 2021, 11:41 PM

[M] Media Search: Center loading icon under grid when quick view is openClosed, ResolvedPublicActions

Description

Details

Event Timeline

[M] Media Search: Center loading icon under grid when quick view is open
Closed, ResolvedPublic
Actions