Page MenuHomePhabricator

Wrong "contest this deletion" links on Page Curation
Closed, ResolvedPublic

Description

See, for example, https://en.wikipedia.org/w/index.php?title=User_talk:Gotagirlcrush&oldid=828761788

Talk:User:<username> is not a valid link nor namespace. Maybe you should not hardcore the namespaces as it happens on https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/e412b6b63f44a74dbb78a931ed35209cc0fc5ec9/NewPagesFeed_Templates.xml#L387 and several other instances.

When it comes to pages not in NS_MAIN, that's going to fail.

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 4 2018, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Also, not sure why I generate two log entries for a single deletion tag.

Instead of Talk:{{{1}}} it should use {{TALKPAGENAME:{{{1}}}}}. Patch coming.

Change 421073 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/PageTriage@master] Use {{TALKPAGE:{{{article}}} instead of Talk:{{{article}}}

https://gerrit.wikimedia.org/r/421073

Change 421073 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use {{TALKPAGE:{{{article}}} instead of Talk:{{{article}}}

https://gerrit.wikimedia.org/r/421073

MarcoAurelio closed this task as Resolved.Apr 5 2018, 5:41 PM
MarcoAurelio assigned this task to Catrope.

Patch merged so let's call this resolved. Will reopen in case there are errors.