Page MenuHomePhabricator
Create Task
Maniphest T188866

Wrong "contest this deletion" links on Page Curation
Closed, ResolvedPublic
Actions

Description

See, for example, https://en.wikipedia.org/w/index.php?title=User_talk:Gotagirlcrush&oldid=828761788

Talk:User:<username> is not a valid link nor namespace. Maybe you should not hardcore the namespaces as it happens on https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/e412b6b63f44a74dbb78a931ed35209cc0fc5ec9/NewPagesFeed_Templates.xml#L387 and several other instances.

When it comes to pages not in NS_MAIN, that's going to fail.

Details

SubjectRepoBranchLines +/-
Use {{TALKPAGE:{{{article}}} instead of Talk:{{{article}}}mediawiki/extensions/PageTriagemaster+22 -22
Customize query in gerrit

Event Timeline

MarcoAurelio created this task.Mar 4 2018, 4:43 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 4 2018, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MarcoAurelio added a comment.Mar 4 2018, 4:47 PM

Also, not sure why I generate two log entries for a single deletion tag.

MarcoAurelio updated the task description. (Show Details)Mar 4 2018, 6:37 PM
• Catrope subscribed.Mar 20 2018, 6:16 PM

Instead of Talk:{{{1}}} it should use {{TALKPAGENAME:{{{1}}}}}. Patch coming.

MarcoAurelio added a comment.Mar 21 2018, 10:34 AM

Thank you @Catrope.

gerritbot subscribed.Mar 21 2018, 5:13 PM

Change 421073 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/PageTriage@master] Use {{TALKPAGE:{{{article}}} instead of Talk:{{{article}}}

https://gerrit.wikimedia.org/r/421073

gerritbot added a project: Patch-For-Review.Mar 21 2018, 5:13 PM
Jdforrester-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Apr 4 2018, 10:47 PM
Jdforrester-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Apr 4 2018, 10:54 PM

Change 421073 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use {{TALKPAGE:{{{article}}} instead of Talk:{{{article}}}

https://gerrit.wikimedia.org/r/421073

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 4 2018, 11:01 PM
MarcoAurelio closed this task as Resolved.Apr 5 2018, 5:41 PM
MarcoAurelio assigned this task to • Catrope.
MarcoAurelio removed a project: Patch-For-Review.

Patch merged so let's call this resolved. Will reopen in case there are errors.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits