Page MenuHomePhabricator

Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store
Closed, ResolvedPublic1 Estimated Story Points

Description

We changed behaviour from using indexes to using hashes back in 14b5fbc3979e9064d22ad7225f256a967658394f in 2016, but left the class name unchanged.

Also change method names: .index -> .hash, and .indexes -> .hashAll

Also change various property names throughout the system, the most important being .originalDomElementsIndex .originalDomElementsHash in hash objects. This will change the computed hash strings in some tests.

Event Timeline

Change 416398 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

https://gerrit.wikimedia.org/r/416398

Change 416653 had a related patch set uploaded (by Divec; owner: Divec):
[mediawiki/extensions/VisualEditor@master] Follow-through rename of IndexValueStore->HashValueStore

https://gerrit.wikimedia.org/r/416653

Change 416398 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

https://gerrit.wikimedia.org/r/416398

Change 416678 had a related patch set uploaded (by Divec; owner: Divec):
[mediawiki/extensions/Cite@master] Follow-through rename of originalDomElementsIndex->originalDomElementsHash

https://gerrit.wikimedia.org/r/416678

Change 416653 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca771b8bc)

https://gerrit.wikimedia.org/r/416653

Change 416678 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Follow-through rename of originalDomElementsIndex->originalDomElementsHash

https://gerrit.wikimedia.org/r/416678

Deskana set the point value for this task to 1.