Page MenuHomePhabricator
Create Task
Maniphest T188900

Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We changed behaviour from using indexes to using hashes back in 14b5fbc3979e9064d22ad7225f256a967658394f in 2016, but left the class name unchanged.

Also change method names: .index -> .hash, and .indexes -> .hashAll

Also change various property names throughout the system, the most important being .originalDomElementsIndex .originalDomElementsHash in hash objects. This will change the computed hash strings in some tests.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Citemaster+6 -6Follow-through rename of originalDomElementsIndex->originalDomElementsHash
mediawiki/extensions/VisualEditormaster+23 -23Update VE core submodule to master (ca771b8bc)
VisualEditor/VisualEditormaster+643 -650[BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore
Customize query in gerrit

Related Objects

Event Timeline

dchan created this task.Mar 5 2018, 9:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2018, 9:37 AM
gerritbot added a subscriber: gerritbot.Mar 5 2018, 9:39 AM

Change 416398 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

https://gerrit.wikimedia.org/r/416398

gerritbot added a project: Patch-For-Review.Mar 5 2018, 9:39 AM
dchan added a project: Technical-Debt.Mar 5 2018, 9:39 AM
dchan moved this task from To Triage to Current work on the VisualEditor board.Mar 5 2018, 9:43 AM
dchan edited projects, added VisualEditor (Current work); removed VisualEditor.
dchan moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Mar 6 2018, 9:09 AM

Change 416653 had a related patch set uploaded (by Divec; owner: Divec):
[mediawiki/extensions/VisualEditor@master] Follow-through rename of IndexValueStore->HashValueStore

https://gerrit.wikimedia.org/r/416653

gerritbot added a comment.Mar 6 2018, 12:41 PM

Change 416398 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore

https://gerrit.wikimedia.org/r/416398

gerritbot added a comment.Mar 6 2018, 1:07 PM

Change 416678 had a related patch set uploaded (by Divec; owner: Divec):
[mediawiki/extensions/Cite@master] Follow-through rename of originalDomElementsIndex->originalDomElementsHash

https://gerrit.wikimedia.org/r/416678

gerritbot added a comment.Mar 6 2018, 1:14 PM

Change 416653 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ca771b8bc)

https://gerrit.wikimedia.org/r/416653

gerritbot added a comment.Mar 6 2018, 1:33 PM

Change 416678 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Follow-through rename of originalDomElementsIndex->originalDomElementsHash

https://gerrit.wikimedia.org/r/416678

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 3:01 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Mar 8 2018, 2:46 PM
Deskana closed this task as Resolved.Mar 14 2018, 1:17 PM
Deskana set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL