Page MenuHomePhabricator
Create Task
Maniphest T188963

TagMultiselectWidget double clicking or marking or changing the cursor placement doesn't work in some cases
Closed, ResolvedPublic
Actions

Description

After quite an investigation, it seems this bug is due to onMouseDown on the $target ending with 'return false;' -- the $target is "safe" to do that when it doesn't include the input, but in cases where the input is inline, it is inside the $target and is getting the onMouseDown of the parent,which in turn completely invalidates any attempt to mark, move the cursor, or double-click to mark.

Details

SubjectRepoBranchLines +/-
TagMultiselectWidget: Only apply `onMouseDown` if not in inputoojs/uimaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Mar 6 2018, 12:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2018, 12:54 AM
gerritbot subscribed.Mar 6 2018, 12:54 AM

Change 416615 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] TagMultiselectWidget: Only apply onMouseDown if not in input

https://gerrit.wikimedia.org/r/416615

gerritbot added a project: Patch-For-Review.Mar 6 2018, 12:54 AM
Mooeypoo claimed this task.Mar 6 2018, 12:54 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Mar 6 2018, 3:59 AM
gerritbot added a comment.Mar 6 2018, 10:30 PM

Change 416615 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: Only apply onMouseDown if not in input

https://gerrit.wikimedia.org/r/416615

Mooeypoo merged a task: T182818: TagMultiselectWidget with inline input has inconsistent double- and triple-click behavior.Mar 7 2018, 1:25 AM
Mooeypoo added subscribers: Volker_E, Pginer-WMF, matmarex.
Volker_E closed this task as Resolved.Mar 7 2018, 5:53 AM
Volker_E triaged this task as High priority.
Volker_E moved this task from Reviewing to OOUI-0.25.3 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.25.3); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL