Page MenuHomePhabricator

"Filter" and "Show" buttons doesn't update language dynamically
Closed, ResolvedPublic

Description

"Filter" and "Show" buttons have their i18n messages as "wdqs-ve-filter" and "wdqs-ve-show" respectively. After the page loaded in English, I chose Portuguese as language, then except "Filter" and "Show" all other remaining values are getting dynamically updated. These "Filter" and "Show" doesn't update until the page is refreshed. Sometimes after refreshing it shows "wdqs-ve-filter" and "wdqs-ve-show" instead of the translation in Portuguese.

Images :
No proper translation of both buttons on choosing languages other than English


Refreshing page multiple times sometimes results

Event Timeline

Restricted Application added projects: Wikidata, Discovery. · View Herald TranscriptMar 11 2018, 4:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I am able to reproduce this issue I think there is some problem with

.text( this._i18n( 'filter' ) )

and

.text( this._i18n( 'show' ) )

There might be some problem at this._i18n() [ not being updated till the page refreshes]

Change Id002b498ea should fix this, so hopefully this problem should be resolved with the next query service deployment. (Not sure why @gerritbot didn’t leave comments about that change here…)

Gopavasanth closed this task as Resolved.Sep 23 2018, 9:35 AM
Gopavasanth claimed this task.
Gopavasanth removed a project: Patch-For-Review.