Page MenuHomePhabricator
Create Task
Maniphest T189421

"Filter" and "Show" buttons doesn't update language dynamically
Closed, ResolvedPublic
Actions

Description

"Filter" and "Show" buttons have their i18n messages as "wdqs-ve-filter" and "wdqs-ve-show" respectively. After the page loaded in English, I chose Portuguese as language, then except "Filter" and "Show" all other remaining values are getting dynamically updated. These "Filter" and "Show" doesn't update until the page is refreshed. Sometimes after refreshing it shows "wdqs-ve-filter" and "wdqs-ve-show" instead of the translation in Portuguese.

Images :
No proper translation of both buttons on choosing languages other than English

bug1(1).png (237×1 px, 10 KB)

Refreshing page multiple times sometimes results
bugreport(1).png (239×1 px, 11 KB)

Details

SubjectRepoBranchLines +/-
Translate "Filter" and "show" buttons dynamicallywikidata/query/guimaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Gopavasanth created this task.Mar 11 2018, 4:54 PM
Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptMar 11 2018, 4:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mbch331 edited projects, added Wikidata Query UI; removed Discovery-ARCHIVED, Wikidata-Query-Service.Mar 11 2018, 6:41 PM
Rammanojpotla subscribed.Mar 12 2018, 3:56 PM
Rammanojpotla added a comment.Mar 12 2018, 6:36 PM

I am able to reproduce this issue I think there is some problem with

.text( this._i18n( 'filter' ) )

and

.text( this._i18n( 'show' ) )

There might be some problem at this._i18n() [ not being updated till the page refreshes]

Rammanojpotla updated the task description. (Show Details)Mar 17 2018, 4:03 PM
gerritbot added a project: Patch-For-Review.Mar 17 2018, 4:17 PM
Rammanojpotla mentioned this in rWDQG4d025674f912: Translate "Filter" and "show" buttons dynamically.Mar 17 2018, 4:19 PM
Rammanojpotla mentioned this in rWDQGf72511abc24f: Translate "Filter" and "show" buttons dynamically.Mar 19 2018, 2:28 PM
Rammanojpotla mentioned this in rWDQG88c76a21901e: Translate "Filter" and "show" buttons dynamically.Mar 19 2018, 3:03 PM
Lucas_Werkmeister_WMDE merged a task: T190422: On WDQS some messages are not translated when switching languages.Mar 22 2018, 3:47 PM
Lucas_Werkmeister_WMDE added a subscriber: • iecetcwcpggwqpgciazwvzpfjpwomjxn.
Lucas_Werkmeister_WMDE added subscribers: gerritbot, Lucas_Werkmeister_WMDE.

Change Id002b498ea should fix this, so hopefully this problem should be resolved with the next query service deployment. (Not sure why @gerritbot didn’t leave comments about that change here…)

Gopavasanth closed this task as Resolved.Sep 23 2018, 9:35 AM
Gopavasanth claimed this task.
Gopavasanth removed a project: Patch-For-Review.
Gopavasanth reassigned this task from Gopavasanth to Rammanojpotla.Oct 15 2018, 11:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL