| Jdlrobson | |
| Mar 23 2018, 6:46 PM |
| F16004514: articles-ltr.svg | |
| Mar 23 2018, 7:40 PM |
| F16004513: articles-rtl.svg | |
| Mar 23 2018, 7:40 PM |
| F16004115: multiple-articles.svg | |
| Mar 23 2018, 7:03 PM |
Follow up work is needed for T168392.
We appear to be wrestling with mw-ui-icon styles due to a bad icon that we're using - all icons should be 24 pixels by 24 pixels by standard and this one is 26 by 32
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Standardise disambiguation icon | mediawiki/extensions/Popups | master | +16 -14 |
Change 421604 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] WIP: Standardise disambiguation icon
It should be 20x20px with our new icon set.
LTR/RTL versions:
This icon is non standard because it is used in context as a visual illustrative element and not in action/button context. we have 20x20 icons* as standard size.
in this case, we required the illustration to be different size. almost double the 20x20. maybe we need to use different technique than mw-ui icon here.
*24x24 on mw-ui with 2px padding which we need to fix but that's another topic
We have large, regular and small icons.
in this case, we required the illustration to be different size. almost double the 20x20. maybe we need to use different technique than mw-ui icon here.
It doesn't look that way to me... we're showing it the same size as every other icon
I've swapped in @Volker_E icons and there's absolutely no visual difference. Thanks @Volker_E and now they work nicely in RTL mode.
There should never be a reason to stray from the non-standard icons. Honestly..!!
Change 421604 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Standardise disambiguation icon
