Page MenuHomePhabricator
Create Task
Maniphest T190782

Zooming in or out in wikistats shouldn't alter the number of metrics shown
Closed, ResolvedPublic
Actions

Description

@Nuria mentioned that because of the level of zoom in her Chrome, the UI was switching to the 2 metric per area layout, which at first I thought was related to the operation we perform based on the pixel ratio of the device. It's actually related to the scaling of DOM elements when zooming. Check out the computed width of the application when we zoom in one step:

Screen Shot 2018-03-27 at 10.20.47 AM.png (85×512 px, 12 KB)

Which makes the UI toggle to 2 metrics, as 1023.99 is below the 1024px threshold.

Funny thing is, this only happens in every other zoom step. If we zoom in again the width goes back to 1024px, and so on.

Details

SubjectRepoBranchLines +/-
Prevents zooming from changing the number of metrics shown per areaanalytics/wikistats2master+12 -3
Customize query in gerrit

Event Timeline

• fdans created this task.Mar 27 2018, 8:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2018, 8:22 AM
gerritbot subscribed.Mar 27 2018, 8:30 AM

Change 422102 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] Prevents zooming in site from changing the number of metrics shown per area

https://gerrit.wikimedia.org/r/422102

gerritbot added a project: Patch-For-Review.Mar 27 2018, 8:30 AM
• Nuria added a comment.Mar 27 2018, 2:43 PM

Funny thing is, this only happens in every other zoom step. If we zoom in again the width goes back to 1024px, and so on.

Right, i saw that too . The devicepixelratio reported changes.

• fdans added a comment.Mar 27 2018, 2:49 PM

@Nuria but the issue you reported was caused by computed width of the app container switching between 1024 and 1023.99. Even though the pixel ration was changing too (as it should), that wasn't causing the threshold jump.

Milimetric subscribed.Mar 27 2018, 3:01 PM

oh! good investigation, my bad then

• Nuria moved this task from Next Up to In Code Review on the Analytics-Kanban board.Mar 27 2018, 3:09 PM
• Nuria added a comment.Mar 27 2018, 5:54 PM

Even though the pixel ration was changing too (as it should), that wasn't causing the threshold jump.

the point i wanted to make was that the computation result changed cause the picxelRatio changed, we agree that it should not happen that way.

gerritbot added a comment.Mar 28 2018, 9:27 AM

Change 422102 merged by Fdans:
[analytics/wikistats2@master] Prevents zooming from changing the number of metrics shown per area

https://gerrit.wikimedia.org/r/422102

• Nuria closed this task as Resolved.Mar 29 2018, 10:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL