Page MenuHomePhabricator

Unit tests for Newsletter extension failing in Wikimedia CI (ApiNewsletterSubscribeTest)
Closed, ResolvedPublic

Description

Unit tests for Newsletter extension are failing in Wikimedia CI. This is preventing all merges.

Example: https://gerrit.wikimedia.org/r/#/c/422092/ https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-jessie/40241/console

18:46:50 There were 2 errors:
18:46:50 
18:46:50 1) ApiNewsletterSubscribeTest::testApiNewsletterForSubscribingNewsletter
18:46:50 Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
18:46:50 Query: SELECT  COUNT(*) AS `rowcount`  FROM (SELECT  1  FROM `unittest_nl_subscriptions`    WHERE nls_newsletter_id = '1' AND (subscriber_id IS NOT NULL)  ) `tmp_count`     
18:46:50 Function: ApiNewsletterSubscribeTest::testApiNewsletterForSubscribingNewsletter
18:46:50 Error: 1054 Unknown column 'subscriber_id' in 'where clause' (127.0.0.1:3306)
18:46:50 
18:46:50 
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1302
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1091
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1497
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1629
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/Newsletter/tests/api/ApiNewsletterSubscribeTest.php:71
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:420
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/maintenance/doMaintenance.php:94
18:46:50 
18:46:50 2) ApiNewsletterSubscribeTest::testApiNewsletterForUnsubscribingNewsletter
18:46:50 Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
18:46:50 Query: SELECT  COUNT(*) AS `rowcount`  FROM (SELECT  1  FROM `unittest_nl_subscriptions`    WHERE nls_newsletter_id = '1' AND (subscriber_id IS NOT NULL)  ) `tmp_count`     
18:46:50 Function: ApiNewsletterSubscribeTest::testApiNewsletterForUnsubscribingNewsletter
18:46:50 Error: 1054 Unknown column 'subscriber_id' in 'where clause' (127.0.0.1:3306)
18:46:50 
18:46:50 
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1302
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1091
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1497
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/includes/libs/rdbms/database/Database.php:1629
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/Newsletter/tests/api/ApiNewsletterSubscribeTest.php:101
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:420
18:46:50 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/maintenance/doMaintenance.php:94
18:46:50 
18:46:50 FAILURES!
18:46:50 Tests: 1647, Assertions: 13844, Errors: 2, Skipped: 2.