Page MenuHomePhabricator

Text within page previews is including in 'find on page' results
Closed, DeclinedPublic

Description

Reported initially by User: Wurgl

Steps:

  1. With page previews enabled
  2. Navigate to any article (example: https://en.wikipedia.org/wiki/2003_Atlantic_hurricane_season)
  3. Perform a browser find for a term (example: period)
  4. Note the number of matches (example: 2 instances)
  5. Hover over an article link to display a preview (use a preview that contains a matching term)
  6. With the preview open perform the word search again (example: period)

Expected Result:
Text within a page preview is not searchable using browser find.

Actual Result:
There are additional matching terms. In the example, there are now 3 instances.

Frequency 5/5

Note - There is a windows specific side effect that the user mentioned. Using F3 one can cycle through the matching words. This is how the user discovered it. One can also see it on Mac and Chromebook.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2018, 11:34 PM
ovasileva triaged this task as Medium priority.Apr 9 2018, 11:27 AM
Jdlrobson added a subscriber: Jdlrobson.

When a preview closes, we do remove it from the page. If the page preview is open and contains a term that is being searched for it's impossible for it not for it to be included in the instance count as it's in the page.

The instance in the preview is not actually searchable. As soon as the page preview is hidden the word is no longer in the page thus not searchable. In Firefox the search count updates but others may not.

I would advise we decline this task there's little we can do here as this is browser specific without breaking accessibility (e.g. faking text via CSS).

ovasileva closed this task as Declined.Apr 18 2018, 10:24 AM
ovasileva added a subscriber: ovasileva.

Sounds good to me - it's an edge case and it seems any solutions carry more risk than gain.