Page MenuHomePhabricator

Fix broken IS.php line about "epcoordinator" for arbcom@cswiki
Closed, ResolvedPublic

Description

A mistake has recently been introduced when changing IS.php and moved line saying 'epcoordinator' => [ 'noratelimit' => true ], // T131684 into the arbcom group definition.

This code cannot work. See codeblock below.

8377     '+cswiki' => [
8378         'autopatrolled' => [ 'autopatrol' => true, ],
8379         'bot' => [ 'ipblock-exempt' => true, ], // T44720
8380         'arbcom' => [ // T63418
8381             'browsearchive' => true,
8382             'deletedhistory' => true,
8383             'deletedtext' => true,
8384             'abusefilter-log-detail' => true,
8385             'abusefilter-view-private' => true, // T174357
8386             'abusefilter-log-private' => true, // T174357
8387             'epcoordinator' => [ 'noratelimit' => true ], // T131684 // This should be after 8388
8388         ],
8389         'rollbacker' => [ 'rollback' => true, ], // T126931
8390         'patroller' => [ // T126931
8391             'patrol' => true,
8392             'patrolmarks' => true,
8393             'unwatchedpages' => true,
8394         ],
8395     ],

Event Timeline

Urbanecm triaged this task as Medium priority.Apr 8 2018, 12:24 PM
Urbanecm lowered the priority of this task from Medium to Low.

Misclick, isn't that urgent.

Urbanecm renamed this task from Remove epcoordinator from arbcom to Fix broken IS.php line about "epcoordinator" for arbcom@cswiki.Apr 8 2018, 12:30 PM
Urbanecm updated the task description. (Show Details)

Change 424851 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Fix broken line that includes a group into a group by mistake

https://gerrit.wikimedia.org/r/424851

Dereckson subscribed.

Issues are caused by commit, and also by lack of unit tests, and not by people per https://victorops.com/blog/blameless-culture.

Issues are caused by commit, and also by lack of unit tests, and not by people per https://victorops.com/blog/blameless-culture.

Sure. We should be improve our unit tests. Any human error should be blocked by system because humans are sometimes make mistake (of course, me too 373137ae2ef0).

Change 424851 merged by jenkins-bot:
[operations/mediawiki-config@master] Fix broken line that includes a group into a group by mistake

https://gerrit.wikimedia.org/r/424851

Mentioned in SAL (#wikimedia-operations) [2018-04-09T13:37:36Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:424851|Fix broken line that includes a group into a group by mistake (T191719)]] (duration: 00m 59s)