Page MenuHomePhabricator

If Item creation fails with a label+description collision, Special:NewItem's creation form points to "NewItem"
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Go to Special:NewItem
  • Enter the label and description of an existing Item (Note: the language has to match)
  • Submit and get an error ("Item Q123 already has label …")
  • Now submit the form again and you will end on the "NewItem"-Item

This is because of EditFilterHookRunner sometimes modifying the context it was given (instead of creating a new one).

Event Timeline

Change 425581 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] EditFilterHookRunner should never alter the given context

https://gerrit.wikimedia.org/r/425581

Change 425581 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EditFilterHookRunner should never alter the given context

https://gerrit.wikimedia.org/r/425581

hoo removed a project: Patch-For-Review.
hoo moved this task from Needs Review to Done on the Wikidata-Ministry-Of-Magic board.