Page MenuHomePhabricator
Create Task
Maniphest T192011

If Item creation fails with a label+description collision, Special:NewItem's creation form points to "NewItem"
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Go to Special:NewItem
  • Enter the label and description of an existing Item (Note: the language has to match)
  • Submit and get an error ("Item Q123 already has label …")
  • Now submit the form again and you will end on the "NewItem"-Item

This is because of EditFilterHookRunner sometimes modifying the context it was given (instead of creating a new one).

Details

SubjectRepoBranchLines +/-
EditFilterHookRunner should never alter the given contextmediawiki/extensions/Wikibasemaster+23 -9
Customize query in gerrit

Related Objects

Event Timeline

hoo created this task.Apr 11 2018, 6:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2018, 6:04 PM
gerritbot subscribed.Apr 11 2018, 6:15 PM

Change 425581 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] EditFilterHookRunner should never alter the given context

https://gerrit.wikimedia.org/r/425581

gerritbot added a project: Patch-For-Review.Apr 11 2018, 6:15 PM
hoo moved this task from Tasks to Needs Review on the Wikidata-Ministry-Of-Magic board.Apr 11 2018, 6:37 PM
matej_suchanek merged a task: T114586: Special:NewItem redirects to https://www.wikidata.org/wiki/NewItem after clicking "create" following a "already exists" message.Apr 12 2018, 7:42 AM
matej_suchanek added subscribers: Stryn, abian, matej_suchanek and 5 others.
gerritbot added a comment.Apr 12 2018, 8:35 AM

Change 425581 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EditFilterHookRunner should never alter the given context

https://gerrit.wikimedia.org/r/425581

hoo closed this task as Resolved.Apr 12 2018, 8:38 AM
hoo removed a project: Patch-For-Review.
hoo moved this task from Needs Review to Done on the Wikidata-Ministry-Of-Magic board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 12 2018, 9:00 AM
matej_suchanek unsubscribed.Apr 12 2018, 2:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits