Page MenuHomePhabricator

npm test of GettingStarted is failing due to stylelint just outputs dots and number of errors
Closed, ResolvedPublicPRODUCTION ERROR

Description

https://gerrit.wikimedia.org/r/#/c/424729/ trigged https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/34849/console which shows:

11:57:45 Running "stylelint:all" (stylelint) task
11:57:48 
11:57:48 resources/lightbulb/lightbulb.flyout.less
11:57:48  .. .  .  ...                              ...        
11:57:48   . .  .                                              
11:57:48     .  .                                              
11:57:48  .. .  .  ...                              ...        
11:57:48   . .  .                                              
11:57:48     .  .
11:57:48 
11:57:48 ✖ 2 problems

The whitespaces and dots are not helpful.
This blocks merged on GettingStarted extension

It looks similar to T190072 or T190269

Event Timeline

hashar subscribed.

T190072 is a generic bug for stylelint. The repository needs the dependencies to be updated iirc.

The linked patch set is the update of the dependencies:

grunt-stylelint             0.9.0  →  0.10.0
stylelint                   8.2.0  →   9.2.0
stylelint-config-wikimedia  0.4.2  →   0.4.3

Or which version is needed of stylelint?

I dont know but T190072 is the generic bug. Seems Kartographer has the same issue as well :\

T190072 is closed, I have comment some days ago that the suggested version of stylelint used on AbuseFilter extension does not help, nobody response, so I have created a new one to keep it track, because it seems not a generic bug for me at time of task creation.
But with the problem also in Kartograhper it looks more generic

Failing linter fixed with https://gerrit.wikimedia.org/r/#/c/426140/
The other issue is tracked in the other task

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM