Page MenuHomePhabricator

Visual Editor: Cite > Manual > Basic not stripping unwanted formatting
Closed, ResolvedPublic

Description

This is a bug that has previously been fixed but has re-appeared.

On Trove (the Australian library content aggregator) everything comes with a pre-formatted Wikipedia citation which normally can be directly copied from Trove and pasted into Cite>Manual>Basic where it is "magically" transformed. Over the past day or so, this has stopped working and pasting the pre-formatted Wikipedia citations intto Cite>Manual>Basic stopped transforming.

Example from the QWiki Club session yesterday was this edit on Shire of Paroo

https://en.wikipedia.org/w/index.php?title=Shire_of_Paroo&type=revision&diff=836664183&oldid=824272885

while trying to add the citation for

https://trove.nla.gov.au/newspaper/article/20691595

Having found this newspaper article, the user went to the "i" in a circle on the left-hand tool bar which generates a number of citation formats

image.png (899×1 px, 726 KB)

image.png (1×908 px, 163 KB)

which was then pasted into Cite > Manual > Basic which did not transform the wikitext

image.png (671×1 px, 88 KB)

instead of doing this

image.png (686×1 px, 80 KB)

as it normally does.

The problem was previously blamed on invisible characters / formatting within the text string when copied from the browser. However, the problem was fixed some time ago. The workaround was to paste the text into a absolutely-plain-text tool and then copy it out before pasting into Cite > Manual > Basic (I usually use Notepad on Windows). Unfortunately the club session was using a Mac lab (and none of us were regular Mac users) and we could not find a true "plain text" tool (we thought textedit should have worked but failed to figure out how to do it on its tool bar). The only way I could find to make it work with the group was to switch to source editor and add the citation that way. Unfortunately the group (who are mostly relative newcomers to Wikipedia) don't know source editor so I had to do that edit for the first person to experience the problem and the session collapsed as there was no way the users could continue on their own using VE.

In the Mac Lab we were using iMacs with Safari. However, I am also getting the problem at home with Windows 8.1 and Chrome, so it does not appear to be platform-specific. I am unaware of Trove undergoing any changes in this timeframe.

Please undo whatever changed and broke this. It was working beautifully before.

Event Timeline

I note that we have 1Lib1Ref South starting May 15 so it's important that Visual Editor's citations are working OK with Trove citations since citation is the key element of the campaign.

https://meta.wikimedia.org/wiki/The_Wikipedia_Library/1Lib1Ref

Change 427435 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] PlainTextStringTransferHandler: Forbid for paste again

https://gerrit.wikimedia.org/r/427435

Change 427436 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Add a plain text paste transfer handler for source mode

https://gerrit.wikimedia.org/r/427436

Change 427435 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] PlainTextStringTransferHandler: Forbid for paste again

https://gerrit.wikimedia.org/r/427435

Change 428394 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (04137a1ed)

https://gerrit.wikimedia.org/r/428394

Change 428394 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (04137a1ed)

https://gerrit.wikimedia.org/r/428394

Change 427436 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add a plain text paste transfer handler for source mode

https://gerrit.wikimedia.org/r/427436