Page MenuHomePhabricator
Create Task
Maniphest T192503

Don't blindly delete and reinsert all settings on save
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Right now, on global preference save, we delete all the preferences known to the local wiki and reinsert whole dataset, even if only 1 row has changed. Not only this results in increased DB load, it will also cause deadlocks with sufficient concurrency. Just save only the settings that have changed, like most other places we do similar things (e.g. LinksUpdate in core).

Details

SubjectRepoBranchLines +/-
Make only needed DB operations when saving preferencesmediawiki/extensions/GlobalPreferencesmaster+26 -6
Customize query in gerrit

Event Timeline

MaxSem created this task.Apr 18 2018, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2018, 9:25 PM
• TBolliger edited projects, added Community-Tech; removed Community-Tech-Sprint.May 8 2018, 9:07 PM
• TBolliger moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
• TBolliger moved this task from Needs Discussion to Product backlog on the Community-Tech board.May 8 2018, 9:55 PM
• TBolliger moved this task from Product backlog to Bug backlog on the Community-Tech board.May 8 2018, 10:09 PM
MaxSem moved this task from Bug backlog to Needs Discussion on the Community-Tech board.May 16 2018, 2:34 AM

Let's do this before problems appear.

• TBolliger triaged this task as High priority.May 16 2018, 6:46 PM
• TBolliger subscribed.

👍

IKhitron subscribed.May 24 2018, 4:29 PM
MaxSem updated the task description. (Show Details)Jun 5 2018, 9:29 PM
• TBolliger added a comment.Jun 5 2018, 9:54 PM

Seems like potentially a lot of work. We should discuss if this is a blocker for releasing to all Wikipedias.

• TBolliger set the point value for this task to 3.Jun 5 2018, 11:39 PM
• TBolliger moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
MaxSem claimed this task.Jun 12 2018, 9:45 PM
MaxSem added a project: Community-Tech-Sprint.
Niharika removed a project: Community-Tech.Jun 12 2018, 11:13 PM
gerritbot subscribed.Jun 13 2018, 2:11 AM

Change 440046 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Make only needed DB operations when saving preferences

https://gerrit.wikimedia.org/r/440046

gerritbot added a project: Patch-For-Review.Jun 13 2018, 2:11 AM
MaxSem moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.Jun 13 2018, 2:11 AM
gerritbot added a comment.Jun 14 2018, 1:45 AM

Change 440046 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Make only needed DB operations when saving preferences

https://gerrit.wikimedia.org/r/440046

MaxSem closed this task as Resolved.Jun 14 2018, 1:48 AM
MaxSem moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 2:00 AM
Niharika moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.Jul 3 2018, 7:36 PM
Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jul 9 2018, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits