Page MenuHomePhabricator
Create Task
Maniphest T192560

Timeless: Use classes for content styles instead of ids (issues with specificity and consistency with other skins)
Closed, ResolvedPublic
Actions

Description

See here, please:
https://ru.wikipedia.org/wiki/Участник:Saint_Johann/Мастерская?useskin=timeless

No other skin does style elements like #mw-content h1 (one ID style equals 255 classes that need to override it). Please move those styles to a class, like .mw-body-content, because supporting Timeless would be extremely costly to others otherwise.

(Also, it is not the best idea to add your own styles to the MediaWiki classes, but that is not the topic of this task.)

Details

SubjectRepoBranchLines +/-
Make misc content styles selector less specificmediawiki/skins/Timelessmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

stjn created this task.Apr 19 2018, 3:13 PM
Isarra renamed this task from Timeless skin has major problems with CSS specificity to Timeless: Use classes for content styles instead of ids (issues with specificity and consistency with other skins).Apr 19 2018, 4:23 PM
Isarra subscribed.Apr 19 2018, 4:25 PM

Ideally should all be consistent with mediawiki.skinning stuff in core.

Evad37 mentioned this in T173151: Watchlist legend alignment is weird.May 2 2018, 1:43 AM
gerritbot subscribed.May 2 2018, 3:36 AM

Change 430281 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Make misc content styles selector less specific

https://gerrit.wikimedia.org/r/430281

gerritbot added a project: Patch-For-Review.May 2 2018, 3:36 AM
gerritbot added a comment.May 3 2018, 4:22 AM

Change 430281 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Make misc content styles selector less specific

https://gerrit.wikimedia.org/r/430281

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 3 2018, 5:00 AM
Isarra closed this task as Resolved.Sep 11 2018, 5:48 PM
Isarra claimed this task.

If this isn't actually fully resolved please yell at me.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits