Page MenuHomePhabricator
Create Task
Maniphest T193564

Regression: When searching all pages appear as watched
Closed, ResolvedPublic
Actions

Description

Steps to Reproduce

  1. Login
  2. Visit any page
  3. Search for "S"
  4. See search results

Expected Results

  • Only pages you have watched appear as watched

Actual Results

  • All pages appear as watched

Environments Observed

Testing Environment for QA

https://en.m.wikipedia.beta.wmflabs.org/wiki/Test_video_hovers#/search

Browser Version

OS Version

Device Model

Device Language

Details

SubjectRepoBranchLines +/-
Fix: boolean conversion of watch in WatchstarGatewaymediawiki/extensions/MobileFrontendwmf/1.32.0-wmf.2+23 -10
Fix: boolean conversion of watch in WatchstarGatewaymediawiki/extensions/MobileFrontendmaster+23 -10
Revert "Hygiene: upgrade WatchstarGateway to formatversion v2"mediawiki/extensions/MobileFrontendmaster+37 -40
Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 1 2018, 7:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2018, 7:54 PM
Jdlrobson raised the priority of this task from Medium to High.May 1 2018, 7:55 PM
Jdlrobson added projects: Regression, Readers-Web-Kanbanana-Board-Old.
Jdlrobson added a subscriber: ovasileva.

Caused by patch in current sprint so moving into sprint @ovasileva

gerritbot subscribed.May 1 2018, 7:55 PM

Change 430122 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Revert "Hygiene: upgrade WatchstarGateway to formatversion v2"

https://gerrit.wikimedia.org/r/430122

gerritbot added a project: Patch-For-Review.May 1 2018, 7:55 PM
Jdlrobson added a comment.May 1 2018, 7:56 PM

Note: this is on the train, and will be lived on mediawiki.org later today and everywhere on Thursday. Is this an unbreak now or something we can live with?

gerritbot added a comment.May 1 2018, 8:02 PM

Change 430131 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: boolean conversion of watch in WatchstarGateway

https://gerrit.wikimedia.org/r/430131

ovasileva added a comment.May 1 2018, 8:03 PM

High is fine but let's fix this asap.

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.May 1 2018, 8:37 PM
gerritbot added a comment.May 1 2018, 10:15 PM

Change 430131 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: boolean conversion of watch in WatchstarGateway

https://gerrit.wikimedia.org/r/430131

gerritbot added a comment.May 1 2018, 10:49 PM

Change 430122 abandoned by Jdlrobson:
Revert "Hygiene: upgrade WatchstarGateway to formatversion v2"

Reason:
Fixed instead by https://gerrit.wikimedia.org/r/430131

https://gerrit.wikimedia.org/r/430122

Jdlrobson assigned this task to ABorbaWMF.May 1 2018, 10:49 PM
Jdlrobson moved this task from To Do to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

Skipping design review as a bug.
Anthony can you have a quick look at this on the beta cluster?
@ovasileva do we need to SWAT the fix as part of sign off or should we let this be broken for a week?

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 1 2018, 11:00 PM
ovasileva moved this task from Triaged but Future to 2017-18 Q4 on the Web-Team-Backlog board.May 2 2018, 1:51 PM
ovasileva added a comment.May 2 2018, 3:28 PM
In T193564#4173133, @Jdlrobson wrote:

Skipping design review as a bug.
Anthony can you have a quick look at this on the beta cluster?
@ovasileva do we need to SWAT the fix as part of sign off or should we let this be broken for a week?

imo we should SWAT it.

gerritbot added a comment.May 2 2018, 3:52 PM

Change 430403 had a related patch set uploaded (by Jdlrobson; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@wmf/1.32.0-wmf.2] Fix: boolean conversion of watch in WatchstarGateway

https://gerrit.wikimedia.org/r/430403

gerritbot added a comment.May 2 2018, 5:14 PM

Change 430403 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.32.0-wmf.2] Fix: boolean conversion of watch in WatchstarGateway

https://gerrit.wikimedia.org/r/430403

Stashbot subscribed.May 2 2018, 5:31 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-02T17:31:55Z] <catrope@tin> Synchronized php-1.32.0-wmf.2/extensions/MobileFrontend/: T193564 (duration: 01m 20s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)); removed MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 2 2018, 6:00 PM
Jdlrobson reassigned this task from ABorbaWMF to ovasileva.May 2 2018, 6:15 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson added a subscriber: ABorbaWMF.

This has now been SWATed. Ready for sign off.

Jdlrobson moved this task from Ready for Signoff to Needs QA on the Readers-Web-Kanbanana-Board-Old board.May 2 2018, 6:16 PM

Whoops. @ABorbaWMF could you confirm what I'm seeing that this is fixed on mediawiki.org ? When searching do you see articles that are watched/unwatched and are you able to toggle their state?

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.May 2 2018, 6:54 PM

Looks good to me on mediawiki

image.png (1×720 px, 266 KB)

image.png (984×540 px, 183 KB)

image.png (667×376 px, 99 KB)

ovasileva closed this task as Resolved.May 3 2018, 10:01 AM

looks good.

• Vvjjkkii renamed this task from Regression: When searching all pages appear as watched to judaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed ovasileva as the assignee of this task.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from judaaaaaaa to Regression: When searching all pages appear as watched.Jul 2 2018, 1:55 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot claimed this task.
CommunityTechBot reassigned this task from CommunityTechBot to ovasileva.
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.
CommunityTechBot subscribed.
CommunityTechBot unsubscribed.Jul 3 2018, 12:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits