Page MenuHomePhabricator
Create Task
Maniphest T193635

Update SingleValueChecker and SingleBestValueChecker for separator parameter
Closed, ResolvedPublic
Actions

Description

Make them get the separator parameter from the ConstraintParameterParser (see T193633) and feed it into the refactored form of Context::getSnakGroup in some fashion (see T193634).

Details

SubjectRepoBranchLines +/-
Use separators in single, single best, multi value constraintsmediawiki/extensions/WikibaseQualityConstraintsmaster+371 -80
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 2 2018, 2:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2018, 2:17 PM
Lucas_Werkmeister_WMDE claimed this task.May 7 2018, 2:30 PM
Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.
gerritbot subscribed.May 7 2018, 3:37 PM

Change 431597 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use separators in single, single best, multi value constraints

https://gerrit.wikimedia.org/r/431597

gerritbot added a project: Patch-For-Review.May 7 2018, 3:37 PM
Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.May 7 2018, 3:37 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.May 14 2018, 12:13 PM
Lucas_Werkmeister_WMDE moved this task from Needs Review to Done on the Wikidata-Ministry-Of-Magic board.
gerritbot added a comment.May 14 2018, 12:27 PM

Change 431597 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use separators in single, single best, multi value constraints

https://gerrit.wikimedia.org/r/431597

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 14 2018, 1:00 PM
• Vvjjkkii renamed this task from Update SingleValueChecker and SingleBestValueChecker for separator parameter to ksdaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Lucas_Werkmeister_WMDE as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from ksdaaaaaaa to Update SingleValueChecker and SingleBestValueChecker for separator parameter.Jul 1 2018, 8:54 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Lucas_Werkmeister_WMDE.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 1:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits