Page MenuHomePhabricator
Create Task
Maniphest T194763

stripUnnecessaryIndentPreNowikis in wikitext serializer is over-aggressive and can introduce semantic diffs
Closed, ResolvedPublic
Actions

Description

[subbu@earth:~/work/wmf/parsoid] echo "<p> *foo</p>" | parse.js --html2wt --scrubWikitext
*foo

It shouldn't strip nowikis if the new leading character is a SOL-sensitive wikitext markup char.

Details

SubjectRepoBranchLines +/-
Whitespace scrubbing should be sensitive to SOL-sensitive markupmediawiki/services/parsoidmaster+61 -5
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.May 15 2018, 2:11 PM
Restricted Application added subscribers: jeblad, Aklapper. · View Herald TranscriptMay 15 2018, 2:11 PM
ssastry triaged this task as Medium priority.May 15 2018, 2:11 PM
ssastry moved this task from Needs Triage to html2wt on the Parsoid board.
gerritbot subscribed.May 16 2018, 10:34 PM

Change 433490 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Whitespace scrubbing should be sensitive to SOL-sensitive markup

https://gerrit.wikimedia.org/r/433490

gerritbot added a project: Patch-For-Review.May 16 2018, 10:34 PM
gerritbot added a comment.May 21 2018, 8:16 PM

Change 433490 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Whitespace scrubbing should be sensitive to SOL-sensitive markup

https://gerrit.wikimedia.org/r/433490

ssastry closed this task as Resolved.May 22 2018, 2:46 PM
Stashbot mentioned this in T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec".May 23 2018, 8:28 PM
Stashbot mentioned this in T194777: Category links are swallowed into definition list output even when they are outside the list.
Stashbot mentioned this in T195317: Comment prevents category from being migrated out of list.
Stashbot mentioned this in T195174: Edge case tokenizing difference.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-05-23T20:28:07Z] <arlolra> Updated Parsoid to dccfeafd (T157418, T194777, T195317, T195174, T194763, T194658)

Stashbot mentioned this in T194658: Empty table cells aren't serialized correctly.May 23 2018, 8:28 PM
• Vvjjkkii renamed this task from stripUnnecessaryIndentPreNowikis in wikitext serializer is over-aggressive and can introduce semantic diffs to 8wcaaaaaaa.Jul 1 2018, 1:09 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 8wcaaaaaaa to stripUnnecessaryIndentPreNowikis in wikitext serializer is over-aggressive and can introduce semantic diffs.Jul 2 2018, 5:17 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot claimed this task.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL