Maniphest T194777

Category links are swallowed into definition list output even when they are outside the list
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	May 15 2018, 4:13 PM

Description

[subbu@earth:~/work/wmf/parsoid] echo -e ":a\n\n[[Category:Foo]]" | parse.js --normalize=parsoid

<dl>
<dd>a <link rel="mw:PageProp/Category" href="./Category:Foo"/></dd>
</dl>

[subbu@earth:~/work/wmf/parsoid] echo -e "*a\n\n[[Category:Foo]]" | parse.js --normalize=parsoid

<ul>
<li>a</li>
</ul>
<link rel="mw:PageProp/Category" href="./Category:Foo"/>

So, we handle regular lists properly.

Details

	Subject	Repo	Branch	Lines +/-
	Migrate trailing categories out of dt/dd tags as well	mediawiki/services/parsoid	master	+22 -3

Customize query in gerrit

Related Objects

Mentioned In: T194658: Empty table cells aren't serialized correctly
T194763: stripUnnecessaryIndentPreNowikis in wikitext serializer is over-aggressive and can introduce semantic diffs
T195174: Edge case tokenizing difference
T195317: Comment prevents category from being migrated out of list
T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec"
Mentioned Here: rGPARdccfeafde935: Protect indented table syntax from indent pre parsing
T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec"
T194658: Empty table cells aren't serialized correctly
T194763: stripUnnecessaryIndentPreNowikis in wikitext serializer is over-aggressive and can introduce semantic diffs
T195174: Edge case tokenizing difference
T195317: Comment prevents category from being migrated out of list

Event Timeline

ssastry created this task.May 15 2018, 4:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2018, 4:13 PM

ssastry triaged this task as Medium priority.May 15 2018, 4:13 PM

ssastry moved this task from Needs Triage to Read Views on the Parsoid board.May 16 2018, 1:40 PM

Change 433377 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Migrate trailing categories out of dt/dd tags as well

https://gerrit.wikimedia.org/r/433377

gerritbot added a project: Patch-For-Review.May 16 2018, 1:52 PM

ssastry claimed this task.May 16 2018, 7:48 PM

Change 433377 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Migrate trailing categories out of dt/dd tags as well

https://gerrit.wikimedia.org/r/433377

ssastry closed this task as Resolved.May 22 2018, 2:46 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T20:28:07Z] <arlolra> Updated Parsoid to dccfeafd (T157418, T194777, T195317, T195174, T194763, T194658)

Stashbot mentioned this in T195317: Comment prevents category from being migrated out of list.May 23 2018, 8:28 PM

Stashbot mentioned this in T195174: Edge case tokenizing difference.

Stashbot mentioned this in T194763: stripUnnecessaryIndentPreNowikis in wikitext serializer is over-aggressive and can introduce semantic diffs.

Stashbot mentioned this in T194658: Empty table cells aren't serialized correctly.

• Vvjjkkii renamed this task from Category links are swallowed into definition list output even when they are outside the list to uwcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed ssastry as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from uwcaaaaaaa to Category links are swallowed into definition list output even when they are outside the list.Jul 2 2018, 5:16 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to ssastry.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Category links are swallowed into definition list output even when they are outside the listClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Category links are swallowed into definition list output even when they are outside the list
Closed, ResolvedPublic
Actions