Maniphest T195136

Echo extension is missing @covers tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 20 2018, 1:52 AM

Description

PHPCS has identified that some of the Echo PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

	Subject	Repo	Branch	Lines +/-
	Re-enable test coverage reporting, add @covers tags	mediawiki/extensions/Echo	master	+7 -1

Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-Other, Test-Coverage.May 20 2018, 1:52 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:52 AM

Legoktm edited projects, added Notifications; removed MediaWiki-extensions-Other.May 20 2018, 1:59 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 20 2018, 1:59 AM

JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-Next-Quarter); removed Collaboration-Team-Triage.May 30 2018, 6:19 PM

JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Next-Quarter).

JTannerWMF moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

kostajh claimed this task.Jun 14 2018, 2:21 PM

Change 440353 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Echo@master] Re-enable test coverage reporting, add @covers tags

https://gerrit.wikimedia.org/r/440353

gerritbot added a project: Patch-For-Review.Jun 14 2018, 3:42 PM

kostajh moved this task from Snack Box to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 14 2018, 4:36 PM

Change 440353 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Re-enable test coverage reporting, add @covers tags

https://gerrit.wikimedia.org/r/440353

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 7:01 PM

• Vvjjkkii renamed this task from Echo extension is missing @covers tags to vmcaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii removed kostajh as the assignee of this task.

• Vvjjkkii triaged this task as High priority.