Page MenuHomePhabricator

Half-broken deletion moved image files to deletion archive without updating DB
Closed, ResolvedPublic


Got a report that this image file was missing:

Confirmed that the file was gone while page and DB entries were intact. Checked the file deletion archive on the file server and found it there:

-rw-r--r-- 1 apache apache 26100 Feb 16 18:24 5cwnvlx4dbx3pzhi7religjue3noolu.jpg

I was able to copy the files back into place, restoring the image.

(One current and one old version, both with the same file hash.)

It looks like someone attempted to delete the image and it was moved into the deletion archive and removed from the regular directories, but the database updates did not complete:

  • image entry remained
  • oldimage entry remained
  • page/revision entries remained
  • no page deletion info
  • no file deletion info
  • no logs

This is bad -- we need to ensure that failure scenarios leave the file intact if the DB can't be successfully updated.

Version: unspecified
Severity: major



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:32 PM
bzimport set Reference to bz17560.

Mass component change for merge of "File/Repo" and "Images and Files"