Page MenuHomePhabricator
Create Task
Maniphest T195613

ErrorException from line 197 of TimelessTemplate.php: PHP Warning: count(): Parameter must be an array or an object that implements Countable
Closed, ResolvedPublic
Actions

Description

Hi, with timeless on mediawiki 1.31 i am seeing this in the logs alot:

[25-May-2018 18:23:34 UTC] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /srv/mediawiki/w/skins/Timeless/TimelessTemplate.php on line 197
2018-05-25 18:23:34 test1 test1wiki: [d9a41fdcc296d73d327dc783] /wiki/Special:SpecialPages   ErrorException from line 197 of /srv/mediawiki/w/skins/Timeless/TimelessTemplate.php: PHP Warning: count(): Parameter must be an array or an object that implements Countable
#0 /srv/mediawiki/w/skins/Timeless/TimelessTemplate.php(197): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/w/skins/Timeless/TimelessTemplate.php(361): TimelessTemplate->getPortlet(string, string)
#2 /srv/mediawiki/w/skins/Timeless/TimelessTemplate.php(41): TimelessTemplate->getMainNavigation()
#3 /srv/mediawiki/w/includes/skins/SkinTemplate.php(251): TimelessTemplate->execute()
#4 /srv/mediawiki/w/includes/OutputPage.php(2388): SkinTemplate->outputPage()
#5 /srv/mediawiki/w/includes/MediaWiki.php(868): OutputPage->output(boolean)
#6 /srv/mediawiki/w/includes/MediaWiki.php(880): MediaWiki->{closure}()
#7 /srv/mediawiki/w/includes/MediaWiki.php(524): MediaWiki->main()
#8 /srv/mediawiki/w/index.php(42): MediaWiki->run()
#9 {main}

I think this was caused by https://github.com/wikimedia/mediawiki-skins-Timeless/commit/212357d9b8a58e0028c6ab521db42420460c81e8

Details

SubjectRepoBranchLines +/-
Fix $count to === against array instead of using count that failsmediawiki/skins/Timelessmaster+3 -3
Fix $count to === against array instead of using count that failsmediawiki/skins/TimelessREL1_31+3 -3
Customize query in gerrit

Event Timeline

Paladox created this task.May 25 2018, 6:43 PM
SamanthaNguyen added a project: PHP 7.2 support.May 25 2018, 6:45 PM
gerritbot subscribed.May 25 2018, 6:49 PM

Change 435205 had a related patch set (by Paladox) published:
[mediawiki/skins/Timeless@master] Add is_array check for count()

https://gerrit.wikimedia.org/r/435205

gerritbot added a project: Patch-For-Review.May 25 2018, 6:49 PM
gerritbot added a comment.May 29 2018, 4:11 PM

Change 435205 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Fix $count to === against array instead of using count that fails

https://gerrit.wikimedia.org/r/435205

gerritbot added a comment.May 29 2018, 4:14 PM

Change 436053 had a related patch set (by Paladox) published:
[mediawiki/skins/Timeless@REL1_31] Fix $count to === against array instead of using count that fails

https://gerrit.wikimedia.org/r/436053

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 29 2018, 5:01 PM
gerritbot added a comment.May 29 2018, 5:18 PM

Change 436053 merged by jenkins-bot:
[mediawiki/skins/Timeless@REL1_31] Fix $count to === against array instead of using count that fails

https://gerrit.wikimedia.org/r/436053

RazeSoldier assigned this task to Paladox.Jun 11 2018, 2:46 PM
RazeSoldier subscribed.

@Paladox Can we mark this task as resolved?

RazeSoldier moved this task from Untriaged to Bundled extensions/skins on the PHP 7.2 support board.Jun 11 2018, 2:46 PM
RazeSoldier moved this task from Backlog to Compatibility on the Timeless board.
Paladox closed this task as Resolved.Jun 11 2018, 2:59 PM

yep.

• Vvjjkkii renamed this task from ErrorException from line 197 of TimelessTemplate.php: PHP Warning: count(): Parameter must be an array or an object that implements Countable to m9baaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Paladox as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: gerritbot.
CommunityTechBot renamed this task from m9baaaaaaa to ErrorException from line 197 of TimelessTemplate.php: PHP Warning: count(): Parameter must be an array or an object that implements Countable.Jul 2 2018, 3:44 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Paladox.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits