Maniphest T195790

Sanitize newlines in local Wikidata description overrides
Closed, ResolvedPublic
Actions

Description

Per T195551: [BUG] Formatting in local descriptions is breaking use of descriptions (example: San Francisco article), newlines in local Wikidata description overrides cause problems for clients and should be removed.
More generally, we should probably ensure that anything that's invalid in a Wikidata description is removed from the local description as well.

Details

	Subject	Repo	Branch	Lines +/-
	Filter newlines from {{SHORTDESC:}} content	mediawiki/extensions/Wikibase	master	+22 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Jhernandez	T195551 [BUG] Formatting in local descriptions is breaking use of descriptions (example: San Francisco article)
		Resolved		Tgr	T195790 Sanitize newlines in local Wikidata description overrides

Event Timeline

Tgr created this task.May 28 2018, 5:49 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMay 28 2018, 5:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tgr added a parent task: T195551: [BUG] Formatting in local descriptions is breaking use of descriptions (example: San Francisco article).May 28 2018, 5:50 PM

Tgr claimed this task.Jun 4 2018, 10:15 AM

Tgr moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 437221 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/Wikibase@master] Filter newlines from {{SHORTDESC:}} content

https://gerrit.wikimedia.org/r/437221

gerritbot added a project: Patch-For-Review.Jun 4 2018, 11:52 AM

Tgr moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 4 2018, 4:30 PM

Change 437221 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Filter newlines from {{SHORTDESC:}} content

https://gerrit.wikimedia.org/r/437221

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 7 2018, 4:00 PM

Tgr closed this task as Resolved.Jun 18 2018, 4:22 PM

• Vvjjkkii renamed this task from Sanitize newlines in local Wikidata description overrides to p4baaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Tgr as the assignee of this task.

• Vvjjkkii triaged this task as High priority.