Page MenuHomePhabricator
Create Task
Maniphest T195854

Inspectors not quite tall enough in Firefox
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Doesn't affect the MW link inspector, probably due to it's complex layout, but the standalone link inspector and the language inspector have no bottom padding:

image.png (172×428 px, 10 KB)

image.png (108×415 px, 9 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (73e80ba80)mediawiki/extensions/VisualEditormaster+1 -1
Add expanded=false to FragmentInspector's containerVisualEditor/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.May 29 2018, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2018, 2:39 PM
Esanders added a comment.May 29 2018, 2:41 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/381455/

Esanders added a project: Regression.May 29 2018, 2:41 PM
Esanders claimed this task.May 29 2018, 2:50 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders set the point value for this task to 1.
gerritbot subscribed.May 29 2018, 2:51 PM

Change 436026 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Add expanded=false to FragmentInspector's container

https://gerrit.wikimedia.org/r/436026

gerritbot added a project: Patch-For-Review.May 29 2018, 2:51 PM
gerritbot added a comment.May 29 2018, 3:13 PM

Change 436026 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Add expanded=false to FragmentInspector's container

https://gerrit.wikimedia.org/r/436026

gerritbot added a comment.May 29 2018, 3:41 PM

Change 436043 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (73e80ba80)

https://gerrit.wikimedia.org/r/436043

gerritbot added a comment.May 29 2018, 4:54 PM

Change 436043 merged by Esanders:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (73e80ba80)

https://gerrit.wikimedia.org/r/436043

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 29 2018, 5:01 PM
Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.May 29 2018, 5:05 PM
Jdforrester-WMF edited projects, added Browser-Support-Firefox, VisualEditor-EditingTools; removed Patch-For-Review.
• Deskana closed this task as Resolved.May 31 2018, 1:02 PM
• Vvjjkkii renamed this task from Inspectors not quite tall enough in Firefox to x2baaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from x2baaaaaaa to Inspectors not quite tall enough in Firefox.Jul 2 2018, 3:25 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Esanders.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot set the point value for this task to 1.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL