Page MenuHomePhabricator

Diffs erroneously show lines moved away
Closed, DuplicatePublic

Description

On itwiki we noticed that sometimes diffs are wrong, showing a moved line while they shouldn't and thus conflicting with the actual page content. For instance, there are this and this diff which made me think of a problem with content model, but then this diff came up on an article. Specifically, in this last diff you can see the line

| data giappone = 30 ottobre 2015<ref name="firstvolume" />

moved down, after

| data italia = 11 aprile 2018<ref name="firstvolumeit" />

while if you check the actual article text you see that the diff is completely wrong.

Event Timeline

Aklapper renamed this task from Diffs erroneously show lines moved away to Diffs erroneously does not always recognize lines that were only moved.May 30 2018, 11:58 AM

@Aklapper I'm not sure about the rename. Reading again the description I see that I haven't been totally clear, but with

the diff is completely wrong

I meant that those line are actually in inverted order: diff shows (1),(2) while in article they are (2),(1). So actually they weren't moved at all

Aklapper renamed this task from Diffs erroneously does not always recognize lines that were only moved to Diffs erroneously show lines moved away.May 30 2018, 12:48 PM

Ah, sorry. Missed that.

matej_suchanek added a subscriber: matej_suchanek.

I have got another test case:

obrazek.png (485×1 px, 20 KB)

obrazek.png (619×1 px, 24 KB)

IIRC, there was an update in the diffing algorithm, hence adding Regression.

Vvjjkkii renamed this task from Diffs erroneously show lines moved away to 8zbaaaaaaa.Jul 1 2018, 1:06 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Daimona renamed this task from 8zbaaaaaaa to Diffs erroneously show lines moved away.Jul 1 2018, 12:35 PM
Daimona raised the priority of this task from High to Needs Triage.
Daimona updated the task description. (Show Details)
Daimona added a subscriber: Aklapper.