Maniphest T195977

Button "Restore all settings" does not have enough width for its text
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	He7d3r
	May 30 2018, 2:10 PM

Description

English: https://en.wikipedia.org/wiki/special:preferences/reset?uselang=en

Captura de tela de 2018-05-30 11-06-23.png (768×1 px, 167 KB)

Portuguese: https://pt.wikipedia.org/wiki/special:preferences/reset?uselang=pt

Captura de tela de 2018-05-30 11-04-13.png (768×1 px, 170 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Special:Preferences/reset: Always use OOUI not the deprecated vform	mediawiki/core	master	+1 -3

Customize query in gerrit

Related Objects

Duplicates Merged Here: T196170: Preferences "restore default settings" button unreadable (cropped)
T196148: "Restore all default settings" button not wide enough; button text cut at the end

Event Timeline

He7d3r created this task.May 30 2018, 2:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2018, 2:10 PM

This is coming from the mw-ui-vform class on the <form>, which shouldn't be applied on this screen AFAICT?

Note that it looks fine in the replacement, OOUI-based version of the form: https://en.wikipedia.org/wiki/special:preferences/reset?uselang=en&ooui=1

Change 436315 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Special:Preferences/reset: Use inline, not vform, in non-OOUI mode

https://gerrit.wikimedia.org/r/436315

gerritbot added a project: Patch-For-Review.May 30 2018, 3:38 PM

Change 436315 merged by jenkins-bot:
[mediawiki/core@master] Special:Preferences/reset: Always use OOUI not the deprecated vform

https://gerrit.wikimedia.org/r/436315

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 30 2018, 9:00 PM

Fixed in master by just always using the OOUI-based version of the form.

Mainframe98 merged a task: T196148: "Restore all default settings" button not wide enough; button text cut at the end.Jun 1 2018, 12:21 PM

Mainframe98 added a subscriber: Guycn2.

Krinkle merged a task: T196170: Preferences "restore default settings" button unreadable (cropped).Jun 1 2018, 3:40 PM

Krinkle subscribed.

• Vvjjkkii renamed this task from Button "Restore all settings" does not have enough width for its text to izbaaaaaaa.Jul 1 2018, 1:07 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Jdforrester-WMF as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from izbaaaaaaa to Button "Restore all settings" does not have enough width for its text.Jul 2 2018, 4:15 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Jdforrester-WMF.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

	F18615728: Captura de tela de 2018-05-30 11-04-13.png
	May 30 2018, 2:10 PM

	F18615721: Captura de tela de 2018-05-30 11-06-23.png
	May 30 2018, 2:10 PM

Button "Restore all settings" does not have enough width for its textClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Button "Restore all settings" does not have enough width for its text
Closed, ResolvedPublic
Actions