Page MenuHomePhabricator
Create Task
Maniphest T196043

wikidiff2 repo doesn't have LICENSE in source nor distribution, nor individual files
Closed, ResolvedPublic
Actions

Description

Or i missed it..
I'm assuming that this means it's GPLv2 per our default policy, but we should definitely make it explicit.

https://gerrit.wikimedia.org/g/mediawiki/php/wikidiff2/+/refs/heads/master

adding tim as initial committer

Details

SubjectRepoBranchLines +/-
Add COPYING and document licensing problems in READMEmediawiki/php/wikidiff2master+344 -0
Relicense from GPL to MIT licensemediawiki/php/wikidiff2master+21 -6
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.May 31 2018, 7:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2018, 7:53 AM
TheDJ removed • tstarling as the assignee of this task.May 31 2018, 7:54 AM
TheDJ added a subscriber: • tstarling.
Legoktm subscribed.May 31 2018, 7:55 AM

I guess we unintentionally removed this in 47372f83285460b52f74433d7997a454ba3c1a66 :( In aa064fba953f03b4fe4dea6da1065f5adf9c8c90 it was clarified that it is GPL v2 or later. We should re-add that to master...

• tstarling added a comment.May 31 2018, 12:53 PM

PHP extensions should absolutely not be GPL. The PHP group refuses to distribute them due to incompatibility with the PHP license. Resulting binaries cannot be distributed under any license. MIT is acceptable and often used in this ecosystem.

• tstarling added a subscriber: akosiaris.EditedJun 1 2018, 2:32 AM

The license in debian/copyright was added in Jan 2014 236f2dffb0ce3dec8ca80b6389aabdc2a40744af by @akosiaris . I'll send an email to people who contributed after that date about relicensing.

gerritbot subscribed.Jun 1 2018, 2:45 AM

Change 436720 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/php/wikidiff2@master] Add LICENSE file indicating MIT license

https://gerrit.wikimedia.org/r/436720

gerritbot added a project: Patch-For-Review.Jun 1 2018, 2:45 AM
Legoktm moved this task from Backlog to License switches on the Software-Licensing board.Jun 1 2018, 2:58 AM
gerritbot added a comment.Jun 1 2018, 5:01 AM

Change 436720 abandoned by Tim Starling:
Relicense from GPL to MIT license

https://gerrit.wikimedia.org/r/436720

gerritbot added a comment.Jun 1 2018, 5:27 AM

Change 436723 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/php/wikidiff2@master] Add COPYING and document licensing problems in README

https://gerrit.wikimedia.org/r/436723

gerritbot added a comment.Jun 1 2018, 6:07 AM

Change 436723 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Add COPYING and document licensing problems in README

https://gerrit.wikimedia.org/r/436723

Legoktm closed this task as Resolved.Jun 1 2018, 6:18 AM
Legoktm claimed this task.
Legoktm mentioned this in T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities.

Well, the license is now explicit in the repository. I filed T196132 to figure out the PHP / GPL license incompatibility.

• Vvjjkkii renamed this task from wikidiff2 repo doesn't have LICENSE in source nor distribution, nor individual files to oxbaaaaaaa.Jul 1 2018, 1:07 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Legoktm as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from oxbaaaaaaa to wikidiff2 repo doesn't have LICENSE in source nor distribution, nor individual files.Jul 2 2018, 3:22 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Legoktm.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits