Maniphest T196342

Header save button disabled when nothing to save
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As an editor I want to enjoy consistent user interface behavior across wikidata.

Acceptance criteria:

Lexeme header in edit mode shows the "publish" button as disabled whilst the information in the form equals the state retrieved at page load

GIVEN I am on the Lexeme (header) part of a Lexeme page
WHEN  I switch to the edit mode using the edit button
THEN  The save button is disabled whilst no information is changed through the user interface

GIVEN I am on the Lexeme (header) part of a Lexeme page
AND   I switch to the edit mode using the edit button
WHEN  I add a lemma with any value and spelling variant
AND   No validation is violated
THEN  The save button is enabled and can be clicked

Info:

This behavior can be observed e.g. for the editing of items (see screenshot), or lexeme forms

Bildschirmfoto vom 2018-06-04 11-52-41.png (609×1 px, 110 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Show save button disabled when the lexeme header has no changes	mediawiki/extensions/WikibaseLexeme	master	+194 -64
	Introduce LemmaList for better separation of concerns	mediawiki/extensions/WikibaseLexeme	master	+172 -35

Customize query in gerrit

Related Objects

Mentioned In: rEWLE4d293bf6e5c4: Show save button disabled when the lexeme header has no changes
rEWLE72214802ae32: Show save button disabled when the lexeme header has no changes
rEWLE6949244aad18: Introduce LemmaList for better separation of concerns
rEWLE40620c41eaa2: Introduce LemmaList for better separation of concerns
rEWLE65b56e4c9158: Introduce LemmaList for better separation of concerns
rEWLE5fb1089c5e96: Introduce LemmaList for better separation of concerns
rEWLEf042a664bbd4: Introduce LemmaList for better separation of concerns
rEWLE22a1c473f2c2: Introduce LemmaList for better separation of concerns
T193636: [Bug] new representation same language code overwrites existing representation
T195372: Prevent entering of lemmas with the same spelling variant

Event Timeline

• Pablo-WMDE created this task.Jun 4 2018, 10:06 AM

• Pablo-WMDE mentioned this in T195372: Prevent entering of lemmas with the same spelling variant.Jun 4 2018, 4:06 PM

• Pablo-WMDE mentioned this in T193636: [Bug] new representation same language code overwrites existing representation.Jun 5 2018, 11:32 AM

• Pablo-WMDE moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.Jun 6 2018, 1:19 PM

• Pablo-WMDE set the point value for this task to 5.Jun 6 2018, 1:29 PM

Jakob_WMDE claimed this task.Jun 7 2018, 9:47 AM

Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration0.Jun 7 2018, 9:49 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration0 board.

Change 438013 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Introduce LemmaList for better separation of concerns

https://gerrit.wikimedia.org/r/438013

gerritbot added a project: Patch-For-Review.Jun 7 2018, 2:02 PM

Jakob_WMDE mentioned this in rEWLE22a1c473f2c2: Introduce LemmaList for better separation of concerns.Jun 7 2018, 2:02 PM

Jakob_WMDE mentioned this in rEWLEf042a664bbd4: Introduce LemmaList for better separation of concerns.Jun 7 2018, 3:31 PM

Jakob_WMDE mentioned this in rEWLE5fb1089c5e96: Introduce LemmaList for better separation of concerns.Jun 7 2018, 3:39 PM

Jakob_WMDE mentioned this in rEWLE65b56e4c9158: Introduce LemmaList for better separation of concerns.Jun 7 2018, 3:51 PM

Jakob_WMDE mentioned this in rEWLE40620c41eaa2: Introduce LemmaList for better separation of concerns.Jun 8 2018, 9:20 AM

Jakob_WMDE mentioned this in rEWLE6949244aad18: Introduce LemmaList for better separation of concerns.Jun 8 2018, 12:45 PM

Change 438013 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce LemmaList for better separation of concerns

https://gerrit.wikimedia.org/r/438013

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 8 2018, 2:01 PM

Change 438248 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Show save button disabled when the lexeme header has no changes

https://gerrit.wikimedia.org/r/438248

Jakob_WMDE mentioned this in rEWLE72214802ae32: Show save button disabled when the lexeme header has no changes.Jun 8 2018, 2:42 PM

Jakob_WMDE mentioned this in rEWLE4d293bf6e5c4: Show save button disabled when the lexeme header has no changes.

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration0 board.Jun 11 2018, 2:16 PM

Change 438248 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Show save button disabled when the lexeme header has no changes

https://gerrit.wikimedia.org/r/438248

Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration0 board.Jun 12 2018, 1:58 PM

Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration1.Jun 13 2018, 9:19 AM

• Pablo-WMDE moved this task from To Do to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 9:25 AM

Lydia_Pintscher closed this task as Resolved.Jun 15 2018, 4:54 PM

Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration1 board.

Lydia_Pintscher added a subscriber: Lea_Lacroix_WMDE.