Page MenuHomePhabricator

Header save button disabled when nothing to save
Closed, ResolvedPublic5 Story Points

Description

As an editor I want to enjoy consistent user interface behavior across wikidata.

Acceptance criteria:

  • Lexeme header in edit mode shows the "publish" button as disabled whilst the information in the form equals the state retrieved at page load
GIVEN I am on the Lexeme (header) part of a Lexeme page
WHEN  I switch to the edit mode using the edit button
THEN  The save button is disabled whilst no information is changed through the user interface

GIVEN I am on the Lexeme (header) part of a Lexeme page
AND   I switch to the edit mode using the edit button
WHEN  I add a lemma with any value and spelling variant
AND   No validation is violated
THEN  The save button is enabled and can be clicked

Info:

  • This behavior can be observed e.g. for the editing of items (see screenshot), or lexeme forms

Event Timeline

Pablo-WMDE set the point value for this task to 5.Jun 6 2018, 1:29 PM

Change 438013 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Introduce LemmaList for better separation of concerns

https://gerrit.wikimedia.org/r/438013

Change 438013 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce LemmaList for better separation of concerns

https://gerrit.wikimedia.org/r/438013

Change 438248 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Show save button disabled when the lexeme header has no changes

https://gerrit.wikimedia.org/r/438248

Change 438248 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Show save button disabled when the lexeme header has no changes

https://gerrit.wikimedia.org/r/438248

Vvjjkkii renamed this task from Header save button disabled when nothing to save to dpbaaaaaaa.Jul 1 2018, 1:06 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii triaged this task as High priority.
Vvjjkkii removed Jakob_WMDE as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii edited subscribers, added: Jakob_WMDE; removed: gerritbot.
CommunityTechBot set the point value for this task to 5.Jul 1 2018, 10:48 PM
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot assigned this task to Jakob_WMDE.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot closed this task as Resolved.
CommunityTechBot renamed this task from dpbaaaaaaa to Header save button disabled when nothing to save.
CommunityTechBot edited subscribers, added: gerritbot; removed: Jakob_WMDE.