Page MenuHomePhabricator
Create Task
Maniphest T196793

FormatMetadataTest::testInvalidDate fails on PHP 7.2
Closed, ResolvedPublic
Actions

Description

4) FormatMetadataTest::testInvalidDate
Valid metadata extracted
Failed asserting that false is not equal to false.
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/media/FormatMetadataTest.php:23
/home/travis/build/wikimedia/mediawiki/tests/phpunit/MediaWikiTestCase.php:420
/home/travis/build/wikimedia/mediawiki/maintenance/doMaintenance.php:94

Details

SubjectRepoBranchLines +/-
Guard against uncountable tag valuesmediawiki/coreREL1_31+9 -4
Guard against uncountable tag valuesmediawiki/coremaster+8 -4
Customize query in gerrit

Event Timeline

Reedy created this task.Jun 9 2018, 2:46 AM
Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptJun 9 2018, 2:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy removed a project: Commons.Jun 9 2018, 2:49 AM
• Vvjjkkii renamed this task from FormatMetadataTest::testInvalidDate fails on PHP 7.2 to ucbaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from ucbaaaaaaa to FormatMetadataTest::testInvalidDate fails on PHP 7.2.Jul 2 2018, 3:03 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Jul 28 2018, 9:27 PM

Change 443206 had a related patch set uploaded (by MaxSem; owner: Samwilson):
[mediawiki/core@master] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/443206

gerritbot added a project: Patch-For-Review.Jul 28 2018, 9:27 PM
gerritbot added a comment.Jul 28 2018, 9:43 PM

Change 443206 merged by jenkins-bot:
[mediawiki/core@master] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/443206

gerritbot added a comment.Jul 28 2018, 9:45 PM

Change 448976 had a related patch set uploaded (by Paladox; owner: Samwilson):
[mediawiki/core@REL1_31] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/448976

MaxSem closed this task as Resolved.Jul 28 2018, 9:46 PM
MaxSem assigned this task to Samwilson.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 28 2018, 10:00 PM
gerritbot added a comment.Aug 2 2018, 11:07 PM

Change 448976 merged by jenkins-bot:
[mediawiki/core@REL1_31] Guard against uncountable tag values

https://gerrit.wikimedia.org/r/448976

ReleaseTaggerBot added a project: MW-1.31-release-notes.Aug 3 2018, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits