Maniphest T196841

Invisible checkbox in notification when switching from visual to source code editing
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Cirdan
	Jun 10 2018, 11:47 AM

Description

It was reported that when switching from visual to source code editing, the checkbox which allows to permanently disable the switch notification is invisible:

The relevant part of the HTML:

<span class="oo-ui-widget oo-ui-widget-enabled oo-ui-inputWidget oo-ui-checkboxInputWidget" aria-disabled="false">
    <input tabindex="0" aria-disabled="false" class="oo-ui-inputWidget-input" value="" id="ooui-1" type="checkbox">
    <span class="oo-ui-checkboxInputWidget-checkIcon oo-ui-widget oo-ui-widget-enabled oo-ui-iconElement oo-ui-iconElement-icon oo-ui-icon-check oo-ui-iconWidget oo-ui-image-invert" aria-disabled="false"></span>
</span>

The problematic CSS is this rule which is in effect when it should not be:

.oo-ui-widget .oo-ui-iconElement-icon, .oo-ui-widget .oo-ui-indicatorElement-indicator, .oo-ui-widget.oo-ui-iconElement .oo-ui-widget .oo-ui-iconElement-icon, .oo-ui-widget.oo-ui-indicatorElement .oo-ui-widget .oo-ui-indicatorElement-indicator {
    display: none;
}

How to reproduce the problem:

Log in with a new user account (older accounts usually have disabled this notification permanently)
Open a random article in visual editing mode
Use the pen in the upper right-hand corner of the editor to switch to source code editing
Observe that the checkbox is invisible

Event Timeline

Cirdan created this task.Jun 10 2018, 11:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2018, 11:47 AM

Cirdan updated the task description. (Show Details)Jun 10 2018, 11:57 AM

Esanders added a project: OOUI.Jun 10 2018, 1:16 PM

matmarex closed this task as a duplicate of T194085: Checkbox not rendering inside popup widget.Jun 11 2018, 9:00 PM

• Vvjjkkii renamed this task from Invisible checkbox in notification when switching from visual to source code editing to ibbaaaaaaa.Jul 1 2018, 1:05 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from ibbaaaaaaa to Invisible checkbox in notification when switching from visual to source code editing.Jul 2 2018, 2:58 PM

CommunityTechBot closed this task as a duplicate.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Volker_E moved this task from Backlog to Invalid/Declined/Duplicate on the OOUI board.Aug 21 2018, 11:01 PM

Invisible checkbox in notification when switching from visual to source code editingClosed, DuplicatePublicActions

Description

Event Timeline

Invisible checkbox in notification when switching from visual to source code editing
Closed, DuplicatePublic
Actions