Maniphest T197679

Duplicated feature name in editquality
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	awight
	Jun 19 2018, 12:36 PM

Tags

Referenced Files

None

Subscribers

Description

I noticed that 'feature.revision.diff.words_change' is duplicated in https://github.com/wiki-ai/editquality/blob/master/editquality/feature_lists/wikitext.py#L61-L66

This probably means that we're losing a source of signal, and we should rename one of the features.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		awight	T201518 ORES deployment (Early August)
		Resolved		awight	T197679 Duplicated feature name in editquality

Event Timeline

awight created this task.Jun 19 2018, 12:36 PM

Restricted Application added a project: artificial-intelligence. · View Herald TranscriptJun 19 2018, 12:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

https://github.com/wiki-ai/editquality/pull/163

It would be nice if revscoring threw an exception on duplicate feature names.

Ladsgroup moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jun 25 2018, 10:31 AM

The next step is to rebuild all editquality models...

• Vvjjkkii renamed this task from Duplicated feature name in editquality to 8naaaaaaaa.Jul 1 2018, 1:03 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 8naaaaaaaa to Duplicated feature name in editquality.Jul 2 2018, 1:30 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

awight claimed this task.Aug 7 2018, 6:54 PM

https://github.com/wiki-ai/editquality/pull/169

awight mentioned this in rOEQcc63a375fa6a: Rebuild models to include a new feature for number of markup changes..Aug 7 2018, 9:01 PM

Halfak added a parent task: T201518: ORES deployment (Early August).Aug 8 2018, 2:38 PM

awight moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Aug 9 2018, 6:04 PM

awight closed this task as Resolved.Aug 14 2018, 11:45 PM

awight mentioned this in rOEQ723119ee75cc: Rebuild models to include a new feature for number of markup changes..Aug 20 2018, 7:39 PM

awight mentioned this in rOEQ78380ccd3c0c: Rebuild models to include a new feature for number of markup changes. Bug….Dec 17 2018, 6:17 PM

awight mentioned this in rOEQ06ba58e8d4b8: Rebuild models to include a new feature for number of markup changes. Bug….Jan 21 2019, 10:44 PM