Page MenuHomePhabricator
Create Task
Maniphest T197762

Probably wrong usage of "this" in ve.init.mw.DesktopArticleTarget.js
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When reading the code for DAT.saveComplete, I came across an this in line 958. Without looking further into it (and especially without testing anything), I suspect that it should be target instead.

Details

SubjectRepoBranchLines +/-
Follow-up I348b8522: Fix context variablemediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Event Timeline

Schnark created this task.Jun 20 2018, 8:45 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 20 2018, 8:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from Probably wrong usage of this to Probably wrong usage of "this" in ve.init.mw.DesktopArticleTarget.js.Jun 20 2018, 8:46 AM
Esanders subscribed.Jun 20 2018, 6:49 PM

Yes, regressed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/428505/

gerritbot subscribed.Jun 20 2018, 6:51 PM

Change 441248 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Follow-up I348b8522: Fix context variable

https://gerrit.wikimedia.org/r/441248

gerritbot added a project: Patch-For-Review.Jun 20 2018, 6:51 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 20 2018, 6:51 PM
Esanders set the point value for this task to 1.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Jun 20 2018, 7:17 PM

Change 441248 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Follow-up I348b8522: Fix context variable

https://gerrit.wikimedia.org/r/441248

Jdforrester-WMF assigned this task to Esanders.Jun 25 2018, 5:48 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed Patch-For-Review.
• Deskana closed this task as Resolved.Jun 26 2018, 2:43 PM
• Deskana triaged this task as Medium priority.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 30 2018, 2:01 PM
• Vvjjkkii renamed this task from Probably wrong usage of "this" in ve.init.mw.DesktopArticleTarget.js to xlaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from xlaaaaaaaa to Probably wrong usage of "this" in ve.init.mw.DesktopArticleTarget.js.Jul 2 2018, 9:45 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Esanders.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 1.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits